Skip to content

[fix](hive-transaction) skip_checking_acid_version_file need to be forwarded #42225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Oct 22, 2024
Merged

[fix](hive-transaction) skip_checking_acid_version_file need to be forwarded #42225

morningman merged 2 commits into from
Oct 22, 2024

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 21, 2024

followup #42111
the skip_checking_acid_version_file need to be forwarded

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman
Copy link
Contributor Author

morningman commented Oct 21, 2024

run buildall

@morningman morningman mentioned this pull request Oct 21, 2024
Merged
@morningman
Copy link
Contributor Author

morningman commented Oct 21, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

TPC-H: Total hot run time: 41142 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f2e9c15aabd7f4e6fc4f0232da94a49e89c4cd48, data reload: false

------ Round 1 ----------------------------------
q1	17754	7402	7272	7272
q2	2029	283	289	283
q3	12049	1045	1145	1045
q4	10575	878	882	878
q5	7734	3100	3043	3043
q6	240	153	151	151
q7	1038	626	622	622
q8	9372	1960	1983	1960
q9	6539	6483	6385	6385
q10	7081	2467	2416	2416
q11	458	245	254	245
q12	412	217	217	217
q13	17791	3035	3046	3035
q14	247	230	212	212
q15	584	531	514	514
q16	630	592	578	578
q17	977	479	483	479
q18	7400	6582	6736	6582
q19	1348	1020	927	927
q20	469	186	189	186
q21	3939	3110	3176	3110
q22	1118	1006	1002	1002
Total cold run time: 109784 ms
Total hot run time: 41142 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7220	7260	7269	7260
q2	326	238	228	228
q3	3046	2982	2956	2956
q4	2096	1850	1834	1834
q5	5762	5744	5766	5744
q6	231	146	151	146
q7	2262	1870	1819	1819
q8	3367	3598	3398	3398
q9	8936	8974	8975	8974
q10	3600	3588	3595	3588
q11	587	491	482	482
q12	840	629	632	629
q13	9922	3240	3231	3231
q14	307	283	278	278
q15	594	532	522	522
q16	685	659	650	650
q17	1833	1662	1593	1593
q18	8210	7915	7762	7762
q19	1718	1449	1571	1449
q20	2145	1856	1890	1856
q21	5773	5591	5512	5512
q22	1145	1068	1032	1032
Total cold run time: 70605 ms
Total hot run time: 60943 ms

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

TPC-DS: Total hot run time: 191928 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f2e9c15aabd7f4e6fc4f0232da94a49e89c4cd48, data reload: false

query1	855	390	406	390
query2	6243	2151	2228	2151
query3	8686	192	205	192
query4	34447	23447	23556	23447
query5	3501	478	459	459
query6	269	166	171	166
query7	4195	298	287	287
query8	291	242	254	242
query9	9570	2790	2751	2751
query10	455	292	291	291
query11	18037	15241	15310	15241
query12	157	102	100	100
query13	1558	444	411	411
query14	9433	6563	7065	6563
query15	243	171	178	171
query16	8009	456	469	456
query17	1573	627	589	589
query18	2118	316	314	314
query19	229	162	159	159
query20	131	113	119	113
query21	213	104	111	104
query22	4665	4564	4677	4564
query23	35495	34320	34103	34103
query24	11009	2695	2716	2695
query25	635	406	404	404
query26	1390	161	166	161
query27	2620	288	291	288
query28	7699	2440	2454	2440
query29	928	423	413	413
query30	261	154	151	151
query31	1051	809	815	809
query32	98	57	57	57
query33	758	309	312	309
query34	925	524	514	514
query35	892	745	742	742
query36	1088	937	954	937
query37	161	92	94	92
query38	4158	3981	3953	3953
query39	1508	1436	1469	1436
query40	266	100	104	100
query41	50	47	46	46
query42	128	105	100	100
query43	546	502	509	502
query44	1262	801	811	801
query45	198	169	168	168
query46	1168	693	694	693
query47	1952	1845	1874	1845
query48	419	352	342	342
query49	958	436	441	436
query50	815	386	398	386
query51	7208	6980	6967	6967
query52	100	89	86	86
query53	257	184	183	183
query54	992	432	430	430
query55	83	77	80	77
query56	276	287	267	267
query57	1297	1119	1151	1119
query58	237	235	230	230
query59	3431	3226	3416	3226
query60	294	273	274	273
query61	111	102	107	102
query62	847	713	657	657
query63	223	192	186	186
query64	4328	645	616	616
query65	3309	3254	3191	3191
query66	1006	320	301	301
query67	16031	15747	15514	15514
query68	4616	567	577	567
query69	486	292	285	285
query70	1176	1157	1074	1074
query71	336	275	288	275
query72	6382	3989	4025	3989
query73	762	354	362	354
query74	10096	9112	9001	9001
query75	3386	2690	2678	2678
query76	2801	865	900	865
query77	401	303	290	290
query78	10429	9938	9583	9583
query79	1436	595	602	595
query80	1840	440	451	440
query81	581	242	243	242
query82	746	139	137	137
query83	287	135	139	135
query84	273	71	72	71
query85	1590	301	287	287
query86	425	317	316	316
query87	4642	4482	4459	4459
query88	3324	2217	2175	2175
query89	404	290	292	290
query90	2010	188	187	187
query91	137	104	102	102
query92	65	47	50	47
query93	1157	543	541	541
query94	998	312	298	298
query95	354	247	253	247
query96	613	276	281	276
query97	3269	3120	3145	3120
query98	221	207	202	202
query99	1538	1291	1301	1291
Total cold run time: 300127 ms
Total hot run time: 191928 ms

@doris-robot
Copy link

doris-robot commented Oct 21, 2024

ClickBench: Total hot run time: 31.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f2e9c15aabd7f4e6fc4f0232da94a49e89c4cd48, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.49	0.50	0.49
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.56	0.51	0.51
query10	0.55	0.55	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.10
query13	0.61	0.59	0.59
query14	2.81	2.71	2.74
query15	0.90	0.83	0.83
query16	0.39	0.39	0.38
query17	1.01	1.01	1.06
query18	0.20	0.20	0.20
query19	1.96	1.78	2.02
query20	0.01	0.01	0.01
query21	15.37	0.58	0.56
query22	2.53	2.44	1.69
query23	16.94	0.89	0.76
query24	3.38	1.56	0.27
query25	0.24	0.19	0.08
query26	0.44	0.14	0.13
query27	0.04	0.04	0.04
query28	10.60	1.11	1.07
query29	12.56	3.29	3.28
query30	0.24	0.06	0.06
query31	2.87	0.40	0.38
query32	3.25	0.46	0.46
query33	3.03	3.01	3.10
query34	16.95	4.52	4.49
query35	4.59	4.56	4.57
query36	0.66	0.48	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.07 s
Total hot run time: 31.87 s

morningman added a commit that referenced this pull request Oct 21, 2024
@morningman @kaka11chen
[Configuration](transactional-hive) Add `skip_checking_acid_version_f…
701ebe5 
…ile` session var to skip checking acid version file in some hive envs. #42111 #42225 (#42226)

bp #42111 #42225

---------

Co-authored-by: Qi Chen <kaka11.chen@gmail.com>
kaka11chen
kaka11chen approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

PR approved by anyone and no changes requested.

@morningman morningman merged commit bd2d846 into apache:master Oct 22, 2024
morningman added a commit to morningman/doris that referenced this pull request Oct 30, 2024
@morningman
[fix](hive-transaction) skip_checking_acid_version_file need to be fo…
f81d7bd 
…rwarded (apache#42225)

followup apache#42111
the skip_checking_acid_version_file need to be forwarded
This was referenced Oct 30, 2024
Closed
Merged
morningman added a commit that referenced this pull request Oct 31, 2024
@morningman @kaka11chen
[Configuration](transactional-hive) Add `skip_checking_acid_version_f…
fce4695 
…ile` session var to skip checking acid version file in some hive envs. (#42111)(#42225) (#42939)

cherry-pick (#42111)(#42225)

---------

Co-authored-by: Qi Chen <kaka11.chen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

+1 more reviewer

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morningman @doris-robot @kaka11chen @zy-kkk @hubgeter