Skip to content

Conversation

@airborne12
Copy link
Member

Proposed changes

Fix case error as below

2024-10-18 09:44:27.415 ERROR [suite-thread-2] (ScriptContext.groovy:122) - Run test_bloom_filter_hit_with_renamed_column in /home/ubuntu/regression-test/doris_branch-2.1/NEREIDS_ASAN/p0/regression-test/suites/bloom_filter_p0/test_bloom_filter_hit_with_renamed_column.groovy failed
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
Exception in bloom_filter_p0/test_bloom_filter_drop_column.groovy(line 43):


    sql """INSERT INTO ${table_name} values ('1', '1')"""

    qt_select """select * from ${table_name} order by a"""

    // drop column c1
    sql """ALTER TABLE ${table_name} DROP COLUMN c1"""
    // show create table
    def res = sql """SHOW CREATE TABLE ${table_name}"""
    assert res[0][1].contains("\"bloom_filter_columns\" = \"\"")
^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^

    // add new column c1
    sql """ALTER TABLE ${table_name} ADD COLUMN c1 ARRAY<STRING>"""
    // insert data
    sql """INSERT INTO ${table_name} values ('2', null)"""
    // select data
    qt_select """select * from ${table_name} order by a"""
}

Exception:
Assertion failed:
assert res[0][1].contains("\"bloom_filter_columns\" = \"\"")
       |  |  |   |
       |  |  |   false
       |  |  'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);'
       |  ['test_bloom_filter_drop_column', 'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);']
       [['test_bloom_filter_drop_column', 'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);']]

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@airborne12
Copy link
Member Author

run buildall

Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 22, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit 79dd4a3 into apache:master Oct 22, 2024
@airborne12 airborne12 deleted the enhance-case branch October 22, 2024 10:44
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 22, 2024
…pache#42243)

Fix case error as below
```
2024-10-18 09:44:27.415 ERROR [suite-thread-2] (ScriptContext.groovy:122) - Run test_bloom_filter_hit_with_renamed_column in /home/ubuntu/regression-test/doris_branch-2.1/NEREIDS_ASAN/p0/regression-test/suites/bloom_filter_p0/test_bloom_filter_hit_with_renamed_column.groovy failed
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
```

```
Exception in bloom_filter_p0/test_bloom_filter_drop_column.groovy(line 43):

    sql """INSERT INTO ${table_name} values ('1', '1')"""

    qt_select """select * from ${table_name} order by a"""

    // drop column c1
    sql """ALTER TABLE ${table_name} DROP COLUMN c1"""
    // show create table
    def res = sql """SHOW CREATE TABLE ${table_name}"""
    assert res[0][1].contains("\"bloom_filter_columns\" = \"\"")
^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^

    // add new column c1
    sql """ALTER TABLE ${table_name} ADD COLUMN c1 ARRAY<STRING>"""
    // insert data
    sql """INSERT INTO ${table_name} values ('2', null)"""
    // select data
    qt_select """select * from ${table_name} order by a"""
}

Exception:
Assertion failed:
assert res[0][1].contains("\"bloom_filter_columns\" = \"\"")
       |  |  |   |
       |  |  |   false
       |  |  'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);'
       |  ['test_bloom_filter_drop_column', 'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);']
       [['test_bloom_filter_drop_column', 'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);']]
```
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 22, 2024
…pache#42243)

## Proposed changes

Fix case error as below
```
2024-10-18 09:44:27.415 ERROR [suite-thread-2] (ScriptContext.groovy:122) - Run test_bloom_filter_hit_with_renamed_column in /home/ubuntu/regression-test/doris_branch-2.1/NEREIDS_ASAN/p0/regression-test/suites/bloom_filter_p0/test_bloom_filter_hit_with_renamed_column.groovy failed
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
```

```
Exception in bloom_filter_p0/test_bloom_filter_drop_column.groovy(line 43):


    sql """INSERT INTO ${table_name} values ('1', '1')"""

    qt_select """select * from ${table_name} order by a"""

    // drop column c1
    sql """ALTER TABLE ${table_name} DROP COLUMN c1"""
    // show create table
    def res = sql """SHOW CREATE TABLE ${table_name}"""
    assert res[0][1].contains("\"bloom_filter_columns\" = \"\"")
^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^

    // add new column c1
    sql """ALTER TABLE ${table_name} ADD COLUMN c1 ARRAY<STRING>"""
    // insert data
    sql """INSERT INTO ${table_name} values ('2', null)"""
    // select data
    qt_select """select * from ${table_name} order by a"""
}

Exception:
Assertion failed:
assert res[0][1].contains("\"bloom_filter_columns\" = \"\"")
       |  |  |   |
       |  |  |   false
       |  |  'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);'
       |  ['test_bloom_filter_drop_column', 'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);']
       [['test_bloom_filter_drop_column', 'CREATE TABLE `test_bloom_filter_drop_column` (\n  `a` varchar(150) NULL\n) ENGINE=OLAP\nDUPLICATE KEY(`a`)\nDISTRIBUTED BY HASH(`a`) BUCKETS 1\nPROPERTIES (\n"replication_allocation" = "tag.location.default: 3",\n"min_load_replica_num" = "-1",\n"bloom_filter_columns" = "c1",\n"is_being_synced" = "false",\n"storage_medium" = "hdd",\n"storage_format" = "V2",\n"inverted_index_storage_format" = "V1",\n"light_schema_change" = "true",\n"disable_auto_compaction" = "false",\n"enable_single_replica_compaction" = "false",\n"group_commit_interval_ms" = "10000",\n"group_commit_data_bytes" = "134217728"\n);']]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants