Skip to content

[Opt](config) adjust segment cache #42308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 1 commit into from
Oct 24, 2024
Merged

[Opt](config) adjust segment cache #42308

eldenmoon merged 1 commit into from
Oct 24, 2024

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Oct 23, 2024

For wide tables the default segment cache capacity is relatively small and lead to many cache eviction in high compaction/query load

@doris-robot
Copy link

doris-robot commented Oct 23, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

xiaokang
xiaokang previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon
Copy link
Member Author

eldenmoon commented Oct 23, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Oct 23, 2024

TeamCity be ut coverage result:
Function Coverage: 37.48% (9707/25902)
Line Coverage: 28.73% (80486/280189)
Region Coverage: 28.16% (41627/147832)
Branch Coverage: 24.72% (21148/85562)
Coverage Report: http://coverage.selectdb-in.cc/coverage/72a8cfd77d77476881869b1ca3bf637bf8826805_72a8cfd77d77476881869b1ca3bf637bf8826805/report/index.html

@eldenmoon eldenmoon requested a review from dataroaring October 23, 2024 09:19
dataroaring
dataroaring previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qidaye
qidaye previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon
[Opt](config) adjust segment cache
96a9f94 
For wide tables the default segment cache capacity is relatively small and lead to many cache eviction in high compaction/query load
@eldenmoon eldenmoon dismissed stale reviews from qidaye, dataroaring, and xiaokang via 96a9f94 October 24, 2024 03:26
@eldenmoon
Copy link
Member Author

eldenmoon commented Oct 24, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 24, 2024

TeamCity be ut coverage result:
Function Coverage: 37.30% (9665/25913)
Line Coverage: 28.54% (79992/280248)
Region Coverage: 28.00% (41395/147837)
Branch Coverage: 24.62% (21060/85538)
Coverage Report: http://coverage.selectdb-in.cc/coverage/96a9f9491c4ce5e759faa05c6b7fc3fcbc178bc9_96a9f9491c4ce5e759faa05c6b7fc3fcbc178bc9/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

PR approved by at least one committer and no changes requested.

airborne12
airborne12 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 220744e into apache:master Oct 24, 2024
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
39c4987 
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
This was referenced Oct 24, 2024
Merged
Merged
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
c2fb6c1 
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
8cc28ae 
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (apache#42308)
6bde6d3 
For wide tables the default segment cache capacity is relatively small
and lead to many cache eviction in high compaction/query load
eldenmoon added a commit that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (#42308) (#42436)
ecbd135 
(#42308)
eldenmoon added a commit that referenced this pull request Oct 24, 2024
@eldenmoon
[Opt](config) adjust segment cache (#42308) (#42431)
e6bc8ab 
#42308
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@qidaye qidaye qidaye approved these changes

@xiaokang xiaokang xiaokang left review comments

@dataroaring dataroaring dataroaring left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eldenmoon @doris-robot @xiaokang @airborne12 @qidaye @dataroaring