Skip to content

Do not wrap NULL type expr to IF(TupleIsNull(tids), NULL, expr) #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imay merged 1 commit into from
Aug 11, 2020
Merged

Do not wrap NULL type expr to IF(TupleIsNull(tids), NULL, expr) #4245

imay merged 1 commit into from
Aug 11, 2020

Conversation

@liutang123
Copy link
Contributor

@liutang123 liutang123 commented Aug 4, 2020

for #4241

@liutang123 liutang123 changed the title Do not wrap NULL type tuple Do not wrap NULL type expr to IF(TupleIsNull(tids), NULL, expr) Aug 4, 2020
imay
imay previously approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay added approved Indicates a PR has been approved by one committer. area/sql Issues or PRs related to SQL area/planner Issues or PRs related to the query planner labels Aug 6, 2020
morningman
morningman reviewed Aug 6, 2020
View reviewed changes
imay
imay approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit a480dec into apache:master Aug 11, 2020
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 8, 2025
@mrhhsg
[fix](test) Avoid the configuration item disable_datev1 affecting oth…
3b5b2fb 
…er test cases (apache#52915) (apache#4245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman left review comments

@imay imay imay approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner area/sql Issues or PRs related to SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liutang123 @imay @morningman