Skip to content

[Bug][Ut] Fix UT bug #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
morningman wants to merge 1 commit into from
Closed

[Bug][Ut] Fix UT bug #4246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/util/arrow/row_batch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Status convert_to_arrow_batch(
Status convert_to_row_batch(
const arrow::RecordBatch& batch,
const RowDescriptor& row_desc,
std::shared_ptr<MemTracker> tracker,
const std::shared_ptr<MemTracker>& tracker,
std::shared_ptr<RowBatch>* result);

Status serialize_record_batch(const arrow::RecordBatch& record_batch, std::string* result);
Expand Down
4 changes: 2 additions & 2 deletions be/test/runtime/load_channel_mgr_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ OLAPStatus close_status;
int64_t wait_lock_time_ns;

// mock
DeltaWriter::DeltaWriter(WriteRequest* req, std::shared_ptr<MemTracker> mem_tracker,
DeltaWriter::DeltaWriter(WriteRequest* req, const std::shared_ptr<MemTracker>& mem_tracker,
StorageEngine* storage_engine) :
_req(*req) {
}
Expand All @@ -57,7 +57,7 @@ OLAPStatus DeltaWriter::init() {
return OLAP_SUCCESS;
}

OLAPStatus DeltaWriter::open(WriteRequest* req, std::shared_ptr<MemTracker> mem_tracker, DeltaWriter** writer) {
OLAPStatus DeltaWriter::open(WriteRequest* req, const std::shared_ptr<MemTracker>& mem_tracker, DeltaWriter** writer) {
if (open_status != OLAP_SUCCESS) {
return open_status;
}
Expand Down