Skip to content

Conversation

@hust-hhb
Copy link
Contributor

@hust-hhb hust-hhb commented Oct 25, 2024

pick pr #41636 to branch 2.1

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hust-hhb
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


#pragma once

#include <stdint.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]

Suggested change
#include <stdint.h>
#include <cstdint>

private:
Status _handle_show_delete_bitmap_count(HttpRequest* req, std::string* json_result);

private:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]

Suggested change
private:
Additional context

be/src/http/action/delete_bitmap_action.h:44: previously declared here

private:
^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.03% (9372/26009)
Line Coverage: 27.59% (76977/278971)
Region Coverage: 26.38% (39533/149875)
Branch Coverage: 23.16% (20108/86826)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f0c514e9399df555cc4107808ed766f7dff16c50_f0c514e9399df555cc4107808ed766f7dff16c50/report/index.html

@zhannngchen
Copy link
Contributor

#40204 is optimized for cloud, we don't need to pick it to 2.1?

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.45% (9523/26124)
Line Coverage: 27.93% (78362/280584)
Region Coverage: 26.58% (40183/151162)
Branch Coverage: 23.38% (20405/87266)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8df82a6a12f12926060489ebea2dd903947f66a9_8df82a6a12f12926060489ebea2dd903947f66a9/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.50% (9570/26221)
Line Coverage: 27.93% (78634/281571)
Region Coverage: 26.58% (40340/151745)
Branch Coverage: 23.34% (20442/87566)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6f0f4c2124015928d1af9c8c3be252e502a31861_6f0f4c2124015928d1af9c8c3be252e502a31861/report/index.html

@hust-hhb hust-hhb closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants