Skip to content

Support sequence column for UNIQUE_KEYS Table #4256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yangzhg merged 6 commits into from
Sep 4, 2020
Merged

Support sequence column for UNIQUE_KEYS Table #4256

yangzhg merged 6 commits into from
Sep 4, 2020

Conversation

@Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Aug 5, 2020

For #3930

yangzhg
yangzhg reviewed Aug 10, 2020
View reviewed changes
yangzhg
yangzhg reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You pr may cause CREATE EXTERNAL TABLE from hdfs failed and query failed after create materialize view. Please check it

@Youngwb Youngwb requested a review from yangzhg August 17, 2020 02:41
@Youngwb Youngwb force-pushed the sequence_col branch 3 times, most recently from 9d04603 to 7f278fd Compare August 27, 2020 15:20
@morningman morningman self-assigned this Aug 27, 2020
@morningman morningman added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2020
yangzhg
yangzhg reviewed Aug 28, 2020
View reviewed changes
yangzhg
yangzhg reviewed Aug 28, 2020
View reviewed changes
yangzhg
yangzhg previously approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yangzhg
yangzhg approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Sep 1, 2020
@yangzhg yangzhg merged commit 0687074 into apache:master Sep 4, 2020
@Youngwb Youngwb mentioned this pull request Sep 8, 2020
Closed
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhg yangzhg yangzhg approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Youngwb @yangzhg @morningman