Skip to content

Conversation

@freemandealer
Copy link
Contributor

reset_range enlarges the size if the download size is larger than the original size. TTL LRU queue missed that while still subtracting the larger size when entries were removed from the queue, causing the size metric negative overflow.

Pick #41987

Proposed changes

Issue Number: close #xxx

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@freemandealer
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40232 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a36a42a50f05bb1aed1801eac70ea595434a2d03, data reload: false

------ Round 1 ----------------------------------
q1	18157	7332	7303	7303
q2	2047	147	143	143
q3	10600	1108	1187	1108
q4	10209	668	691	668
q5	7721	2840	2761	2761
q6	229	148	148	148
q7	975	610	597	597
q8	9350	1903	1917	1903
q9	6586	6391	6391	6391
q10	6989	2297	2299	2297
q11	438	242	243	242
q12	393	208	211	208
q13	17775	2973	2910	2910
q14	236	205	226	205
q15	564	506	507	506
q16	649	601	592	592
q17	961	570	538	538
q18	7466	6749	6589	6589
q19	1383	1048	941	941
q20	482	192	197	192
q21	4219	2979	3130	2979
q22	1107	1027	1011	1011
Total cold run time: 108536 ms
Total hot run time: 40232 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7260	7213	7187	7187
q2	317	225	226	225
q3	2869	2717	2732	2717
q4	1875	1660	1638	1638
q5	5371	5399	5405	5399
q6	216	137	136	136
q7	2093	1657	1641	1641
q8	3178	3337	3350	3337
q9	8461	8441	8422	8422
q10	3403	3418	3369	3369
q11	574	460	469	460
q12	752	559	569	559
q13	16901	2947	2951	2947
q14	284	260	280	260
q15	546	542	500	500
q16	712	655	647	647
q17	1771	1577	1538	1538
q18	7674	7360	7420	7360
q19	1622	1529	1496	1496
q20	2004	1780	1763	1763
q21	5160	5120	5008	5008
q22	1131	1000	969	969
Total cold run time: 74174 ms
Total hot run time: 57578 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189465 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a36a42a50f05bb1aed1801eac70ea595434a2d03, data reload: false

query1	976	376	364	364
query2	6519	2043	1997	1997
query3	6705	208	224	208
query4	34045	23416	23456	23416
query5	4417	430	432	430
query6	257	176	166	166
query7	4617	315	296	296
query8	299	235	234	234
query9	9644	2663	2654	2654
query10	496	269	255	255
query11	17869	15080	15106	15080
query12	154	100	100	100
query13	1633	432	392	392
query14	9334	6550	7062	6550
query15	233	170	166	166
query16	8027	496	480	480
query17	1633	572	541	541
query18	2073	309	310	309
query19	206	156	144	144
query20	116	108	109	108
query21	211	103	102	102
query22	4339	4405	4164	4164
query23	34507	34623	33986	33986
query24	12165	2776	2810	2776
query25	558	394	406	394
query26	1117	167	170	167
query27	2988	300	300	300
query28	8133	2490	2485	2485
query29	672	439	439	439
query30	324	158	156	156
query31	1027	781	821	781
query32	93	55	56	55
query33	780	285	278	278
query34	1005	494	497	494
query35	859	704	704	704
query36	1110	936	959	936
query37	203	72	78	72
query38	3944	3821	3840	3821
query39	1481	1416	1431	1416
query40	304	107	105	105
query41	55	51	51	51
query42	108	100	100	100
query43	500	484	481	481
query44	1248	785	788	785
query45	181	168	165	165
query46	1129	733	704	704
query47	1898	1794	1797	1794
query48	451	362	361	361
query49	1297	396	393	393
query50	824	401	407	401
query51	7057	6812	6939	6812
query52	103	93	91	91
query53	261	185	184	184
query54	1063	460	447	447
query55	78	75	77	75
query56	258	255	244	244
query57	1185	1088	1083	1083
query58	238	208	205	205
query59	3020	3089	3092	3089
query60	297	239	248	239
query61	105	101	126	101
query62	862	661	655	655
query63	203	192	184	184
query64	4991	629	600	600
query65	3247	3189	3347	3189
query66	1274	302	297	297
query67	16168	15424	15385	15385
query68	5524	557	556	556
query69	421	249	246	246
query70	1175	1112	1074	1074
query71	360	259	267	259
query72	5929	3897	3821	3821
query73	749	343	334	334
query74	10487	8993	8860	8860
query75	3336	2665	2599	2599
query76	3518	931	1066	931
query77	522	259	258	258
query78	10559	9649	9499	9499
query79	7246	603	596	596
query80	2027	424	419	419
query81	574	243	245	243
query82	1090	117	118	117
query83	258	136	136	136
query84	289	79	84	79
query85	2327	317	289	289
query86	495	301	310	301
query87	4456	4275	4257	4257
query88	5318	2359	2345	2345
query89	498	283	292	283
query90	2143	182	185	182
query91	172	143	145	143
query92	69	47	50	47
query93	6280	557	540	540
query94	1083	279	259	259
query95	351	244	252	244
query96	629	292	282	282
query97	3380	3154	3148	3148
query98	214	200	192	192
query99	1620	1307	1290	1290
Total cold run time: 316273 ms
Total hot run time: 189465 ms

@dataroaring dataroaring merged commit f625bbb into apache:branch-3.0 Oct 29, 2024
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants