-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[chore](profile) add task state in profile #42895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41397 ms |
TPC-DS: Total hot run time: 196798 ms |
ClickBench: Total hot run time: 32.6 s |
be/src/pipeline/pipeline_task.cpp
Outdated
| *eos = status.is<ErrorCode::END_OF_FILE>() ? true : *eos; | ||
| if (*eos) { // just return, the scheduler will do finish work | ||
| _eos = true; | ||
| _task_profile->add_info_string("TaskState", "EOS"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to Finished
| if (*eos) { | ||
| // reach limit, stop the scanners. | ||
| local_state._scanner_ctx->stop_scanners(state); | ||
| local_state._scanner_profile->add_info_string("EOS", "true"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True
3937280 to
45cba10
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
45cba10 to
42ea668
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41378 ms |
TPC-DS: Total hot run time: 196688 ms |
ClickBench: Total hot run time: 33.08 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
Issue Number: close #xxx <!--Describe your changes.-->
PR Body: ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> Cherry-picked from #42895 Co-authored-by: Jerry Hu <mrhhsg@gmail.com>
Proposed changes
Issue Number: close #xxx