Skip to content

[Enhancement](log) Make query relative BE log more reasonable #42900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 1 commit into from
Nov 5, 2024
Merged

[Enhancement](log) Make query relative BE log more reasonable #42900

zhangstar333 merged 1 commit into from
Nov 5, 2024

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Oct 30, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

before we have many info logs which may not useful when a query runs. now we reduced them. keep one info log for each stage below:

  1. query arrive
  2. FE tells to run fragment
  3. query finished

and no others

@doris-robot
Copy link

doris-robot commented Oct 30, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Oct 30, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Oct 30, 2024

TeamCity be ut coverage result:
Function Coverage: 37.95% (9847/25949)
Line Coverage: 29.22% (82000/280631)
Region Coverage: 28.56% (42293/148083)
Branch Coverage: 25.09% (21491/85660)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dd716eb54a537f15a3df2543f6ff802a74a6e2fb_dd716eb54a537f15a3df2543f6ff802a74a6e2fb/report/index.html

HappenLee
HappenLee reviewed Oct 30, 2024
View reviewed changes
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Oct 30, 2024

run buildall

@zclllyybb zclllyybb requested a review from HappenLee October 30, 2024 11:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 30, 2024

TeamCity be ut coverage result:
Function Coverage: 37.89% (9847/25985)
Line Coverage: 29.17% (81995/281124)
Region Coverage: 28.55% (42330/148285)
Branch Coverage: 25.07% (21506/85780)
Coverage Report: http://coverage.selectdb-in.cc/coverage/14ba2824d1b7080a98692ad8e5d0af63ff7ef81f_14ba2824d1b7080a98692ad8e5d0af63ff7ef81f/report/index.html

HappenLee
HappenLee previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 1, 2024
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 1, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 1, 2024

TeamCity be ut coverage result:
Function Coverage: 37.82% (9821/25971)
Line Coverage: 28.99% (81628/281535)
Region Coverage: 28.27% (42156/149137)
Branch Coverage: 24.85% (21387/86076)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c13c74e6cf9273777a60547b8f9e62cc3cb44503_c13c74e6cf9273777a60547b8f9e62cc3cb44503/report/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Nov 4, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 4, 2024

TeamCity be ut coverage result:
Function Coverage: 37.81% (9822/25975)
Line Coverage: 28.99% (81693/281807)
Region Coverage: 28.22% (42111/149199)
Branch Coverage: 24.81% (21368/86140)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3b25838dc13c3446c9e0c676804ecde83dbd63f4_3b25838dc13c3446c9e0c676804ecde83dbd63f4/report/index.html

HappenLee
HappenLee approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR approved by at least one committer and no changes requested.

@zhangstar333 zhangstar333 merged commit cc7e275 into apache:master Nov 5, 2024
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Nov 5, 2024
@zclllyybb
[Enhancement](log) Make query relative BE log more reasonable (apache…
fd5ef13 
…#42900)

Issue Number: close #xxx

before we have many info logs which may not useful when a query runs.
now we reduced them. keep one info log for each stage below:
1. query arrive
2. FE tells to run fragment
3. query finished

and no others
@zclllyybb zclllyybb mentioned this pull request Nov 5, 2024
Merged
@zclllyybb zclllyybb deleted the refactor_log branch November 8, 2024 05:10
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Nov 11, 2024
@zclllyybb
[Enhancement](log) Make query relative BE log more reasonable (apache…
605f5be 
…#42900)

Issue Number: close #xxx

before we have many info logs which may not useful when a query runs.
now we reduced them. keep one info log for each stage below:
1. query arrive
2. FE tells to run fragment
3. query finished

and no others
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Nov 11, 2024
@zclllyybb
[Enhancement](log) Make query relative BE log more reasonable (apache…
a35b1ea 
…#42900)

Issue Number: close #xxx

before we have many info logs which may not useful when a query runs.
now we reduced them. keep one info log for each stage below:
1. query arrive
2. FE tells to run fragment
3. query finished

and no others
@zclllyybb zclllyybb mentioned this pull request Nov 11, 2024
Merged
yiguolei pushed a commit that referenced this pull request Nov 12, 2024
@zclllyybb
[branch-2.1](log) Pick all BE execution log reduction (#43267)
24b79fd 
pick #42383
pick #42900
yiguolei pushed a commit that referenced this pull request Nov 13, 2024
@zclllyybb
[branch-3.0](log) Pick all BE execution log reduction (#43579)
11a9a48 
pick #42383
pick #42900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zclllyybb @doris-robot @HappenLee @zhangstar333 @yiguolei