Skip to content

[fix](Nerieds) fix FoldConstantRuleOnFE too slow when CaseWhen clause nesting multiple layers (#42897) #42907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 3 commits into from
Oct 31, 2024
Merged

[fix](Nerieds) fix FoldConstantRuleOnFE too slow when CaseWhen clause nesting multiple layers (#42897) #42907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db15e52
fix FoldConstantRuleOnFE slow problem
924060929 Oct 30, 2024
2ad0c1f
fix
924060929 Oct 30, 2024
b1180b7
fix
924060929 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class FoldConstantRule implements ExpressionPatternRuleFactory {
public static final FoldConstantRule INSTANCE = new FoldConstantRule();

private static final ExpressionBottomUpRewriter FULL_FOLD_REWRITER = ExpressionRewrite.bottomUp(
FoldConstantRuleOnFE.VISITOR_INSTANCE,
FoldConstantRuleOnFE.PATTERN_MATCH_INSTANCE,
FoldConstantRuleOnBE.INSTANCE
);

Expand Down
3 changes: 0 additions & 3 deletions ...e/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,9 +520,6 @@ public Expression visitCaseWhen(CaseWhen caseWhen, ExpressionRewriteContext cont
Expression defaultResult = null;
if (caseWhen.getDefaultValue().isPresent()) {
defaultResult = caseWhen.getDefaultValue().get();
if (deepRewrite) {
defaultResult = rewrite(defaultResult, context);
}
}
if (foundNewDefault) {
defaultResult = newDefault;
Expand Down
Loading