Skip to content

branch-3.0: [chore](profile) add task state in profile #42981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Nov 7, 2024
Merged

branch-3.0: [chore](profile) add task state in profile #42981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions be/src/pipeline/exec/scan_operator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,6 +1270,7 @@ Status ScanOperatorX<LocalStateType>::get_block(RuntimeState* state, vectorized:
if (*eos) {
// reach limit, stop the scanners.
local_state._scanner_ctx->stop_scanners(state);
local_state._scanner_profile->add_info_string("EOS", "True");
}

return Status::OK();
Expand Down
9 changes: 9 additions & 0 deletions be/src/pipeline/pipeline_task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,12 @@ bool PipelineTask::_wait_to_start() {
}

bool PipelineTask::_is_blocked() {
Defer defer([this] {
if (_blocked_dep != nullptr) {
_task_profile->add_info_string("TaskState", "Blocked");
_task_profile->add_info_string("BlockedByDependency", _blocked_dep->name());
}
});
// `_dry_run = true` means we do not need data from source operator.
if (!_dry_run) {
for (int i = _read_dependencies.size() - 1; i >= 0; i--) {
Expand Down Expand Up @@ -328,6 +334,8 @@ Status PipelineTask::execute(bool* eos) {
RETURN_IF_ERROR(_open());
}

_task_profile->add_info_string("TaskState", "Runnable");
_task_profile->add_info_string("BlockedByDependency", "");
while (!_fragment_context->is_canceled()) {
if (_is_blocked()) {
return Status::OK();
Expand Down Expand Up @@ -391,6 +399,7 @@ Status PipelineTask::execute(bool* eos) {
*eos = status.is<ErrorCode::END_OF_FILE>() ? true : *eos;
if (*eos) { // just return, the scheduler will do finish work
_eos = true;
_task_profile->add_info_string("TaskState", "Finished");
return Status::OK();
}
}
Expand Down