[Refactor](inverted index) refactor inverted index interface in tablet schema #43003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TPC-H: Total hot run time: 41471 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 191990 ms |
ClickBench: Total hot run time: 33.06 s |
Contributor
Author
|
run buildall |
csun5285
force-pushed
the
refactor_index_schema
branch
from
18df067 to
79b8c37
Compare
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41336 ms |
TPC-DS: Total hot run time: 195526 ms |
ClickBench: Total hot run time: 31.8 s |
eldenmoon
reviewed
Nov 1, 2024
airborne12
reviewed
Nov 1, 2024
csun5285
force-pushed
the
refactor_index_schema
branch
from
70bca58 to
b6e22ec
Compare
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41409 ms |
TPC-DS: Total hot run time: 195949 ms |
ClickBench: Total hot run time: 33.16 s |
xiaokang
reviewed
Nov 4, 2024
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41395 ms |
TPC-DS: Total hot run time: 191115 ms |
ClickBench: Total hot run time: 33.07 s |
|
TeamCity be ut coverage result: |
Member
|
run p1 |
Member
|
run cloud_p1 |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Nov 12, 2024
…t schema (apache#43003) ## Proposed changes refactor inverted index interface in tablet schema 1. There's a large amount of similar code ``` for (const auto& index : schema_ptr->indexes()) { if (index.index_type() == IndexType::INVERTED) { .... } } ``` Now it has been changed to ``` for (const auto& index : schema_ptr->inverted_indexes()) { .... } ``` 2. Remove functions with redundant functionality, such as `get_indexes_for_column `, `get_inverted_index_with_index_id` .... 3. Retrieve the index meta for the inverted index. Currently, there are two types: one is `inverted_index(TabletColumn)`, which checks the column type (e.g., if the column type is float, it does not support indexing and will be filtered out); the other is `inverted_index(unique_id, index_suffix)`, which retrieves the index meta for the current column without checking the column type. <!--Describe your changes.-->
airborne12
pushed a commit
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
refactor inverted index interface in tablet schema
Now it has been changed to
Remove functions with redundant functionality, such as
get_indexes_for_column,get_inverted_index_with_index_id....Retrieve the index meta for the inverted index. Currently, there are two types: one is
inverted_index(TabletColumn), which checks the column type (e.g., if the column type is float, it does not support indexing and will be filtered out); the other isinverted_index(unique_id, index_suffix), which retrieves the index meta for the current column without checking the column type.