Skip to content

[test](mv) Fix regression test out text is wrong #43095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 9 commits into from
Nov 18, 2024
Merged

[test](mv) Fix regression test out text is wrong #43095

morrySnow merged 9 commits into from
Nov 18, 2024

Conversation

@seawinde
Copy link
Contributor

@seawinde seawinde commented Nov 1, 2024

What problem does this PR solve?

When shrinking the test data set, the corresponding out file data was not refreshed. As a result, the data in the out file was refreshed again.

There are some tests that hit both materialized views as expected, modifying such corresponding cases.

Issue Number: close #xxx

Related PR:
#40860
#41644

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 1, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@seawinde
Copy link
Contributor Author

seawinde commented Nov 1, 2024

run buildall

morrySnow
morrySnow previously approved these changes Nov 1, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

PR approved by anyone and no changes requested.

zfr9527
zfr9527 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@zfr9527 zfr9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seawinde
Copy link
Contributor Author

seawinde commented Nov 4, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 4, 2024
@seawinde
Copy link
Contributor Author

seawinde commented Nov 5, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 5, 2024

TPC-H: Total hot run time: 41379 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 83f4ea803a62fc1a85107bca72e0d37d0eb02285, data reload: false

------ Round 1 ----------------------------------
q1	17580	7433	7306	7306
q2	2073	163	160	160
q3	10841	1101	1132	1101
q4	10527	867	913	867
q5	7753	3099	3089	3089
q6	241	150	147	147
q7	1018	621	607	607
q8	9351	1953	2017	1953
q9	6555	6414	6471	6414
q10	7107	2420	2419	2419
q11	477	258	263	258
q12	411	221	217	217
q13	17794	2997	2988	2988
q14	228	207	209	207
q15	576	528	517	517
q16	664	595	598	595
q17	986	556	529	529
q18	7305	6774	6721	6721
q19	1333	958	919	919
q20	490	179	184	179
q21	3998	3195	3222	3195
q22	1115	991	992	991
Total cold run time: 108423 ms
Total hot run time: 41379 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7278	7256	7278	7256
q2	326	225	234	225
q3	2978	2947	2961	2947
q4	2110	1885	1821	1821
q5	5754	5713	5797	5713
q6	235	139	144	139
q7	2205	1870	1803	1803
q8	3400	3524	3428	3428
q9	8946	8905	8888	8888
q10	3597	3572	3587	3572
q11	605	507	496	496
q12	845	635	606	606
q13	10364	3221	3237	3221
q14	307	270	272	270
q15	578	529	526	526
q16	688	652	637	637
q17	1872	1627	1650	1627
q18	8299	7694	7692	7692
q19	1732	1508	1643	1508
q20	2152	1863	1968	1863
q21	5612	5433	5342	5342
q22	1152	1076	1053	1053
Total cold run time: 71035 ms
Total hot run time: 60633 ms

@doris-robot
Copy link

doris-robot commented Nov 5, 2024

TPC-DS: Total hot run time: 195782 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 83f4ea803a62fc1a85107bca72e0d37d0eb02285, data reload: false

query1	1199	897	950	897
query2	6210	2081	2042	2042
query3	10809	4086	3887	3887
query4	66993	29524	23659	23659
query5	4914	445	431	431
query6	398	196	171	171
query7	5555	294	290	290
query8	311	228	220	220
query9	9030	2644	2648	2644
query10	462	251	246	246
query11	17271	15364	16028	15364
query12	153	99	98	98
query13	1525	433	429	429
query14	10378	7292	6836	6836
query15	219	192	193	192
query16	7081	442	477	442
query17	1005	563	563	563
query18	1813	300	293	293
query19	199	149	154	149
query20	117	109	110	109
query21	200	99	100	99
query22	4528	4461	4408	4408
query23	35250	34114	34029	34029
query24	6025	2741	2739	2739
query25	500	387	403	387
query26	645	158	156	156
query27	1675	296	289	289
query28	4067	2436	2414	2414
query29	692	423	424	423
query30	233	148	163	148
query31	969	799	807	799
query32	63	64	56	56
query33	419	269	266	266
query34	918	505	518	505
query35	830	737	731	731
query36	1080	964	972	964
query37	124	76	72	72
query38	4369	4258	4332	4258
query39	1491	1456	1405	1405
query40	207	103	102	102
query41	47	47	45	45
query42	109	97	102	97
query43	535	500	495	495
query44	1151	824	831	824
query45	186	166	165	165
query46	1120	697	699	697
query47	1941	1839	1849	1839
query48	407	323	321	321
query49	725	415	408	408
query50	793	397	408	397
query51	7244	7224	7048	7048
query52	103	83	83	83
query53	249	174	181	174
query54	518	408	388	388
query55	78	75	72	72
query56	248	242	238	238
query57	1294	1203	1160	1160
query58	213	199	212	199
query59	3188	2989	3053	2989
query60	279	238	246	238
query61	107	105	108	105
query62	797	676	662	662
query63	209	183	186	183
query64	1346	645	640	640
query65	3240	3201	3237	3201
query66	703	310	304	304
query67	16092	15654	15810	15654
query68	3970	583	573	573
query69	403	247	248	247
query70	1156	1133	1129	1129
query71	355	263	243	243
query72	6087	4045	3959	3959
query73	752	361	355	355
query74	10133	9040	9018	9018
query75	3604	2654	2718	2654
query76	1800	1107	1024	1024
query77	507	294	268	268
query78	10402	9358	9360	9358
query79	1492	584	588	584
query80	882	423	419	419
query81	504	242	239	239
query82	1261	110	119	110
query83	222	139	135	135
query84	283	70	68	68
query85	902	299	295	295
query86	345	299	301	299
query87	4911	4687	4645	4645
query88	3589	2204	2180	2180
query89	410	294	290	290
query90	1991	195	182	182
query91	140	109	103	103
query92	61	47	50	47
query93	1937	549	557	549
query94	813	293	292	292
query95	343	241	245	241
query96	610	278	283	278
query97	2945	2654	2662	2654
query98	208	211	199	199
query99	1601	1309	1307	1307
Total cold run time: 317468 ms
Total hot run time: 195782 ms

@doris-robot
Copy link

doris-robot commented Nov 5, 2024

ClickBench: Total hot run time: 31.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 83f4ea803a62fc1a85107bca72e0d37d0eb02285, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.63	0.10	0.10
query5	0.41	0.39	0.41
query6	1.15	0.65	0.65
query7	0.02	0.02	0.02
query8	0.03	0.03	0.02
query9	0.56	0.49	0.49
query10	0.56	0.55	0.54
query11	0.15	0.10	0.11
query12	0.14	0.11	0.12
query13	0.60	0.59	0.59
query14	2.75	2.75	2.76
query15	0.91	0.83	0.83
query16	0.37	0.40	0.41
query17	1.04	1.07	1.01
query18	0.20	0.20	0.20
query19	1.99	1.88	2.01
query20	0.01	0.00	0.01
query21	15.38	0.61	0.60
query22	2.35	2.43	1.52
query23	16.93	1.07	0.90
query24	2.45	0.46	1.68
query25	0.15	0.18	0.05
query26	0.50	0.14	0.15
query27	0.05	0.04	0.04
query28	10.99	1.08	1.06
query29	12.68	3.24	3.21
query30	0.25	0.07	0.06
query31	2.86	0.38	0.38
query32	3.29	0.45	0.45
query33	3.00	3.07	3.11
query34	16.85	4.42	4.44
query35	4.49	4.45	4.48
query36	0.67	0.47	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.2 s
Total hot run time: 31.77 s

@seawinde
Copy link
Contributor Author

seawinde commented Nov 5, 2024

run buildall

2 similar comments
@seawinde
Copy link
Contributor Author

seawinde commented Nov 5, 2024

run buildall

@morrySnow
Copy link
Contributor

morrySnow commented Nov 6, 2024

run buildall

@seawinde seawinde force-pushed the fix_-agg_sync_mv_regression_out_wrong branch from 02c39d0 to 2dcdb40 Compare November 6, 2024 12:08
@seawinde
Copy link
Contributor Author

seawinde commented Nov 6, 2024

run buildall

@seawinde
Copy link
Contributor Author

seawinde commented Nov 6, 2024

run buildall

@seawinde
Copy link
Contributor Author

seawinde commented Nov 7, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@morrySnow morrySnow merged commit 7c45912 into apache:master Nov 18, 2024
seawinde added a commit to seawinde/doris that referenced this pull request Nov 19, 2024
@seawinde
[test](mv) Fix regression test out text is wrong (apache#43095)
4f0bf80 
When shrinking the test data set, the corresponding out file data was
not refreshed. As a result, the data in the out file was refreshed
again.

There are some tests that hit both materialized views as expected,
modifying such corresponding cases.
@seawinde seawinde mentioned this pull request Nov 19, 2024
Merged
16 tasks
morrySnow pushed a commit that referenced this pull request Nov 22, 2024
@seawinde
[pick](mtmv) Pick some pr to branch 3.0 #41674 #43095 #44164 (#44290)
eeda1ce 
pick from master

commit id 6fdc8a5
PR #41674


commit id 7c45912
PR #43095


commit id 7aec6ff
PR #44164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@zfr9527 zfr9527 zfr9527 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seawinde @doris-robot @morrySnow @zfr9527