Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Aug 10, 2020

Proposed changes

  • Implements the grammar of the batch delete [Proposal] Doris supports batch delete On UNIQUE_KEYS table #4051
  • Process create, alter table when table has delete sign column
  • Support the syntax for enabling the delete column
  • Automatically filtered deleted data in the select statement.
  • Automatically add delete sign when create rollup table
    TODO:
  • Optimize the reading and compaction logic on the be side, so that the data marked as deleted will be completely deleted during base compaction

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on #ISSUE, and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

@yangzhg yangzhg force-pushed the support_batch_delete branch from 984dddf to 3c6aac8 Compare August 10, 2020 11:53
@yangzhg yangzhg force-pushed the support_batch_delete branch from 3c6aac8 to c5387d5 Compare August 11, 2020 01:53
@yangzhg yangzhg force-pushed the support_batch_delete branch from 2192b8d to 924eb33 Compare August 13, 2020 07:54
@yangzhg yangzhg requested a review from morningman August 18, 2020 02:39
@morningman morningman self-assigned this Aug 20, 2020
@morningman morningman added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 20, 2020
morningman
morningman previously approved these changes Aug 20, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@morningman morningman merged commit d61c10b into apache:master Aug 21, 2020
@morningman morningman added the approved Indicates a PR has been approved by one committer. label Aug 21, 2020
@yangzhg yangzhg deleted the support_batch_delete branch September 14, 2020 01:47
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants