Support add new key column for LinkedSchemaChange #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
requested changes
Dec 14, 2018
be/src/olap/segment_group.cpp
Outdated
| if (schema_mapping[i].ref_column == -1) { | ||
| num_new_keys++; | ||
|
|
||
| if (true == column_schema.is_allow_null && column_schema.default_value.length() == 0) { |
Contributor
There was a problem hiding this comment.
first->copy(schema_mapping[i].default_value);
second->copy(schema_mapping[i].default_value);
will be ok.
Contributor
Author
|
Update the commit. I wanted to move ColumnMapping to olap_common.h initially, but I found the ColumnMapping relayed wrapper_field. So I moved ColumnMapping to a single file. |
chaoyli
approved these changes
Dec 14, 2018
| } | ||
| } | ||
|
|
||
|
|
| } | ||
| } | ||
|
|
||
|
|
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 332
In PR 337, I didn't think about this case: user add a new key column to base table.
This PR supports add new key column for LinkedSchemaChange.
I'm not sure SegmentGroup include "olap/schema_change.h" is reasonable and the code smell is good.
@chaoyli Please review this PR. Thanks you.