[Bug] Fix bug that modification of global variable can not be persisted. #4324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/fix
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Aug 21, 2020
…ed. (apache#4324) When setting global variables, such as `set global default_rowset_type=beta`, the operation is not correctly persisted. This CL change the fe meta version to 90. --------------- The main reason for this problem is that for the modification of global variable, we directly use Java's reflection mechanism to modify static member variables in `GlobalVariable` class. But in the persistence method of the `set` operation, we only persist the value stored in the `globalSessionVariable` variable, and this variable does not contain Global Variable. So I added a new OperationType: `OP_GLOBAL_VARIABLE_V2`, and added a `GlobalVarPersistInfo` class to record all changes.
Closed
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When setting global variables, such as
set global default_rowset_type=beta,the operation is not correctly persisted.
This CL change the fe meta version to 90.
The main reason for this problem is that for the modification of global variable,
we directly use Java's reflection mechanism to modify static member variables in
GlobalVariableclass.But in the persistence method of the
setoperation, we only persist the value storedin the
globalSessionVariablevariable, and this variable does not contain Global Variable.So I added a new OperationType:
OP_GLOBAL_VARIABLE_V2,and added a
GlobalVarPersistInfoclass to record all changes.Types of changes
Checklist