Skip to content

[fix] (build index) fix build index coredump #43246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 1 commit into from
Nov 5, 2024
Merged

[fix] (build index) fix build index coredump #43246

airborne12 merged 1 commit into from
Nov 5, 2024

Conversation

@csun5285
Copy link
Contributor

@csun5285 csun5285 commented Nov 5, 2024 •
edited by airborne12
Loading

What problem does this PR solve?

Introduced by #42882

Related PR: #42882

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

TEST

  • Upgrade the BE first, then use build index, and it will core dump.
  • Manual testing shows that it doesn't core dump after the upgrade.
  1. Execute ADD INDEX
  2. Upgrade BE
  3. Execute BUILD INDEX

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 5, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@csun5285
Copy link
Contributor Author

csun5285 commented Nov 5, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 5, 2024

TeamCity be ut coverage result:
Function Coverage: 37.80% (9820/25981)
Line Coverage: 28.96% (81653/281927)
Region Coverage: 28.22% (42111/149236)
Branch Coverage: 24.80% (21368/86162)
Coverage Report: http://coverage.selectdb-in.cc/coverage/10734b37cbde890aced96ef8f3ee81db7098b6f8_10734b37cbde890aced96ef8f3ee81db7098b6f8/report/index.html

airborne12
airborne12 requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case needed

@csun5285
Copy link
Contributor Author

csun5285 commented Nov 5, 2024

Manual Test

@csun5285 csun5285 requested a review from airborne12 November 5, 2024 08:09
qidaye
qidaye approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

airborne12
airborne12 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit 8d741b6 into apache:master Nov 5, 2024
csun5285 added a commit to csun5285/doris that referenced this pull request Nov 6, 2024
@csun5285
[fix] (build index) fix build index coredump (apache#43246)
bc0b9d2 
### What problem does this PR solve?
<!--
You need to clearly describe your PR in this part:

1. What problem was fixed (it's best to include specific error reporting
information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what
is it now, why was it modified, and what possible impacts might there
be.
3. What features were added. Why this function was added.
4. Which codes were refactored and why this part of the code was
refactored.
5. Which functions were optimized and what is the difference before and
after the optimization.

The description of the PR needs to enable reviewers to quickly and
clearly understand the logic of the code modification.
-->

<!--
If there are related issues, please fill in the issue number.
- If you want the issue to be closed after the PR is merged, please use
"close apache#12345". Otherwise, use "ref apache#12345"
-->
Introduced by apache#42882

<!--
If this PR is followup a preivous PR, for example, fix the bug that
introduced by a related PR,
link the PR here
-->
Related PR: apache#42882

Problem Summary:

### Check List (For Committer)

- Test <!-- At least one of them must be included. -->

    - [ ] Regression test
    - [ ] Unit Test
    - [x] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No colde files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

#### TEST
- Upgrade the BE first, then use build index, and it will core dump.
- Manual testing shows that it doesn't core dump after the upgrade.
1. Execute ADD INDEX
2. Upgrade BE
3. Execute BUILD INDEX

- Behavior changed:

    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?

    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- Release note

    <!-- bugfix, feat, behavior changed need a release note -->
    <!-- Add one line release note for this PR. -->
    None

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@csun5285 csun5285 mentioned this pull request Nov 6, 2024
Merged
airborne12 pushed a commit that referenced this pull request Nov 6, 2024
@csun5285
[fix] (build index) fix build index coredump (#43246) (#43298)
5b44e28 
pick from master: #43246
qidaye pushed a commit to qidaye/incubator-doris that referenced this pull request Nov 7, 2024
@csun5285
[fix] (build index) fix build index coredump (apache#43246)
7667064 
### What problem does this PR solve?
<!--
You need to clearly describe your PR in this part:

1. What problem was fixed (it's best to include specific error reporting
information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what
is it now, why was it modified, and what possible impacts might there
be.
3. What features were added. Why this function was added.
4. Which codes were refactored and why this part of the code was
refactored.
5. Which functions were optimized and what is the difference before and
after the optimization.

The description of the PR needs to enable reviewers to quickly and
clearly understand the logic of the code modification.
-->

<!--
If there are related issues, please fill in the issue number.
- If you want the issue to be closed after the PR is merged, please use
"close apache#12345". Otherwise, use "ref apache#12345"
-->
Introduced by apache#42882

<!--
If this PR is followup a preivous PR, for example, fix the bug that
introduced by a related PR,
link the PR here
-->
Related PR: apache#42882

Problem Summary:

### Check List (For Committer)

- Test <!-- At least one of them must be included. -->

    - [ ] Regression test
    - [ ] Unit Test
    - [x] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No colde files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

#### TEST
- Upgrade the BE first, then use build index, and it will core dump.
- Manual testing shows that it doesn't core dump after the upgrade.
1. Execute ADD INDEX
2. Upgrade BE
3. Execute BUILD INDEX

- Behavior changed:

    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?

    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- Release note

    <!-- bugfix, feat, behavior changed need a release note -->
    <!-- Add one line release note for this PR. -->
    None

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@qidaye qidaye mentioned this pull request Nov 7, 2024
Merged
qidaye added a commit that referenced this pull request Nov 7, 2024
@qidaye @csun5285
[fix](build index)Fix build index failed on renamed column (#42882)(#…
12bb38e 
…43246)(#43336) (#43266)

bp #42882 #43246 #43336
We pick these PRs together because they all fix one problem and if not
do so, the regression test won't be passed.

---------

Co-authored-by: Sun Chenyang <csun5285@gmail.com>
Co-authored-by: qidaye <luen@selectdb.com>
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@qidaye qidaye qidaye approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csun5285 @doris-robot @airborne12 @qidaye