Skip to content

[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs #43262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Nov 7, 2024
Merged

[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs #43262

dataroaring merged 3 commits into from
Nov 7, 2024

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Nov 5, 2024 •
edited by gavinchou
Loading

use smart pointer to control the lifespan of JobMeta to avoid nullptr

@freemandealer
[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs
2201360 
use smart pointer to control the lifespan of JobMeta to avoid nullptr

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@doris-robot
Copy link

doris-robot commented Nov 5, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 5, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 5, 2024

TeamCity be ut coverage result:
Function Coverage: 37.86% (9836/25983)
Line Coverage: 29.02% (81823/281917)
Region Coverage: 28.26% (42171/149234)
Branch Coverage: 24.84% (21398/86156)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2201360198f19eebff0110ce8d79b5a525137dfd_2201360198f19eebff0110ce8d79b5a525137dfd/report/index.html

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 5, 2024

run p0

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 5, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 6, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 6, 2024

TeamCity be ut coverage result:
Function Coverage: 37.86% (9836/25982)
Line Coverage: 29.03% (81817/281851)
Region Coverage: 28.26% (42154/149159)
Branch Coverage: 24.85% (21396/86096)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60547049289c19517c755883850a12677c51d867_60547049289c19517c755883850a12677c51d867/report/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9bbe042 into apache:master Nov 7, 2024
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
@freemandealer
[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs (#43262)
9a36ec6 
use smart pointer to control the lifespan of JobMeta to avoid nullptr

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 8, 2024
@github-actions @freemandealer
branch-3.0: [fix](cloud) fix core dump in CloudWarmUpManager::handle_…
4f81a8e 
…jobs (#43404)

Cherry-picked from #43262

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Co-authored-by: zhengyu <freeman.zhang1992@gmail.com>
@XLPE XLPE mentioned this pull request Jun 27, 2025
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@freemandealer @doris-robot @gavinchou @dataroaring