Skip to content

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Nov 6, 2024

  • Add check to avoid alter hdfs property for s3 storage vault or alter s3 propery for hdfs storage vault

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

* Add check to avoid alter hdfs property for s3 storage vault
  or alter s3 propery for hdfs storage vault
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by anyone and no changes requested.

@swjtu-zhanglei
Copy link
Contributor Author

run cloud_p0

Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit 31ea616 into apache:master Nov 8, 2024
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
* Add check to avoid alter hdfs property for s3 storage vault or alter
s3 propery for hdfs storage vault
swjtu-zhanglei added a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Nov 8, 2024
* Add check to avoid alter hdfs property for s3 storage vault or alter
s3 propery for hdfs storage vault
dataroaring pushed a commit that referenced this pull request Nov 10, 2024
Cherry-picked from #43352

Co-authored-by: Lei Zhang <27994433+SWJTU-ZhangLei@users.noreply.github.com>
dataroaring pushed a commit that referenced this pull request Nov 11, 2024
* Add check to avoid alter hdfs property for s3 storage vault or alter
s3 propery for hdfs storage vault
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants