Skip to content

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Nov 6, 2024

What problem does this PR solve?

  • table1 is olapTable
  • mv1 is MTMV create by table1
  • mv2 is MTMV create by table1

reason:

  • mtmv-task-thread-1: refresh mv1, blocked write lock :mv1
  • show partitions: hold read lock: mv1 ,block read lock: table1
  • insert into table1: block write lock: table1
  • mtmv-task-thread-2: refresh mv2, hold read lock: table1, blocked read lock :mv1

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

show partitions: not hold readLock of olapTable and MTMV at same time
getAndCopyPartitionItems: set max wait time

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    fix mtmv deadlock issue

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr
Copy link
Contributor Author

zddr commented Nov 6, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Nov 6, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Nov 7, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Nov 7, 2024

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 2442b9f into apache:master Nov 7, 2024
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
mtmv deadlock when

- table1 is olapTable
- mv1 is MTMV create by table1
- mv2 is MTMV create by table1

reason:
- mtmv-task-thread-1: refresh mv1,  blocked write lock :mv1
- show partitions: hold read lock: mv1 ,block read lock: table1
- insert into table1: block write lock: table1
- mtmv-task-thread-2: refresh mv2, hold read lock: table1, blocked read
lock :mv1

Problem Summary:

show partitions: not hold readLock of olapTable and MTMV at same time
getAndCopyPartitionItems: set max wait time


Co-authored-by: zhangdong <zhangdong@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
mtmv deadlock when

- table1 is olapTable
- mv1 is MTMV create by table1
- mv2 is MTMV create by table1

reason:
- mtmv-task-thread-1: refresh mv1,  blocked write lock :mv1
- show partitions: hold read lock: mv1 ,block read lock: table1
- insert into table1: block write lock: table1
- mtmv-task-thread-2: refresh mv2, hold read lock: table1, blocked read
lock :mv1

Problem Summary:

show partitions: not hold readLock of olapTable and MTMV at same time
getAndCopyPartitionItems: set max wait time


Co-authored-by: zhangdong <zhangdong@selectdb.com>
zddr added a commit to zddr/incubator-doris that referenced this pull request Nov 7, 2024
mtmv deadlock when

- table1 is olapTable
- mv1 is MTMV create by table1
- mv2 is MTMV create by table1

reason:
- mtmv-task-thread-1: refresh mv1,  blocked write lock :mv1
- show partitions: hold read lock: mv1 ,block read lock: table1
- insert into table1: block write lock: table1
- mtmv-task-thread-2: refresh mv2, hold read lock: table1, blocked read
lock :mv1

Problem Summary:

show partitions: not hold readLock of olapTable and MTMV at same time
getAndCopyPartitionItems: set max wait time


Co-authored-by: zhangdong <zhangdong@selectdb.com>
zddr added a commit to zddr/incubator-doris that referenced this pull request Nov 7, 2024
mtmv deadlock when

- table1 is olapTable
- mv1 is MTMV create by table1
- mv2 is MTMV create by table1

reason:
- mtmv-task-thread-1: refresh mv1,  blocked write lock :mv1
- show partitions: hold read lock: mv1 ,block read lock: table1
- insert into table1: block write lock: table1
- mtmv-task-thread-2: refresh mv2, hold read lock: table1, blocked read
lock :mv1

Problem Summary:

show partitions: not hold readLock of olapTable and MTMV at same time
getAndCopyPartitionItems: set max wait time


Co-authored-by: zhangdong <zhangdong@selectdb.com>
morrySnow pushed a commit that referenced this pull request Nov 11, 2024
pick from master #43376

Co-authored-by: zhangdong <zhangdong@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants