Skip to content

branch-2.1: [improvement](statistics)Remove useless stats validation check. #43499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jibing-Li merged 1 commit into from
Nov 12, 2024
Merged

branch-2.1: [improvement](statistics)Remove useless stats validation check. #43499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/ColStatsData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ public String toSQL(boolean roundByParentheses) {
}

public ColumnStatistic toColumnStatistic() {
// For non-empty table, return UNKNOWN if we can't collect ndv value.
// Because inaccurate ndv is very misleading.
if (count > 0 && ndv == 0 && count != nullCount) {
return ColumnStatistic.UNKNOWN;
}
try {
ColumnStatisticBuilder columnStatisticBuilder = new ColumnStatisticBuilder();
columnStatisticBuilder.setCount(count);
Expand Down
8 changes: 0 additions & 8 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatisticsCacheLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@ protected Optional<ColumnStatistic> doLoad(StatisticsCacheKey key) {
}
return null;
}
if (columnStatistic.isPresent()) {
// For non-empty table, return UNKNOWN if we can't collect ndv value.
// Because inaccurate ndv is very misleading.
ColumnStatistic stats = columnStatistic.get();
if (stats.count > 0 && stats.ndv == 0 && stats.count != stats.numNulls) {
columnStatistic = Optional.of(ColumnStatistic.UNKNOWN);
}
}
return columnStatistic;
}

Expand Down
5 changes: 1 addition & 4 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,7 @@ private void doPreHeat() {
final StatisticsCacheKey k =
new StatisticsCacheKey(statsId.catalogId, statsId.dbId, statsId.tblId, statsId.idxId,
statsId.colId);
ColumnStatistic c = ColumnStatistic.fromResultRow(r);
if (c.count > 0 && c.ndv == 0 && c.count != c.numNulls) {
c = ColumnStatistic.UNKNOWN;
}
final ColumnStatistic c = ColumnStatistic.fromResultRow(r);
putCache(k, c);
} catch (Throwable t) {
LOG.warn("Error when preheating stats cache. reason: [{}]. Row:[{}]", t.getMessage(), r);
Expand Down
4 changes: 1 addition & 3 deletions regression-test/suites/statistics/analyze_stats.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2759,9 +2759,7 @@ PARTITION `p599` VALUES IN (599)
logger.info("show column alter_test(id) stats: " + alter_result)
assertEquals(1, alter_result.size())
alter_result = sql """show column cached stats alter_test(id)"""
assertEquals(0, alter_result.size())
alter_result = sql """show column cached stats alter_test(id)"""
assertEquals(0, alter_result.size())
assertEquals(1, alter_result.size())
sql """alter table alter_test modify column id set stats ('row_count'='100', 'ndv'='0', 'num_nulls'='100', 'data_size'='2.69975443E8', 'min_value'='1', 'max_value'='2');"""
alter_result = sql """show column stats alter_test(id)"""
logger.info("show column alter_test(id) stats: " + alter_result)
Expand Down