Skip to content

[Bug]Fix bug that BE crash when load ORC file #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 4 commits into from
Aug 17, 2020
Merged

[Bug]Fix bug that BE crash when load ORC file #4350

morningman merged 4 commits into from
Aug 17, 2020

Conversation

@WingsGo
Copy link
Contributor

@WingsGo WingsGo commented Aug 14, 2020

Fix #4349

@WingsGo
Copy link
Contributor Author

WingsGo commented Aug 14, 2020 •
edited
Loading

For reviewers, I found that ORC include file didn't expose orc::TimezoneError, which is writer in Timezone.hh, I don't know why, maybe it is a wrong design, I will submit a issue to ORC project, currently solution is declare orc::TimezoneError by handle or just catch std::runtime_error exception, I choosen the first solution because I think it is less error-prone and more reasonable.

morningman
morningman previously approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

morningman commented Aug 15, 2020

Maybe you need to rebase to upstream master to make UT happy

@morningman morningman self-assigned this Aug 15, 2020
@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label Aug 15, 2020
@WingsGo
Copy link
Contributor Author

WingsGo commented Aug 15, 2020

Maybe you need to rebase to upstream master to make UT happy

@morningman OK, done~~

morningman
morningman approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. branch-0.13 PR which need to merge to branch 0.13 labels Aug 16, 2020
@morningman morningman merged commit 391d534 into apache:master Aug 17, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Aug 21, 2020
@WingsGo @acelyc111
[Bug]Fix bug that BE crash when load ORC file (apache#4350)
df94c61
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Nov 4, 2025
@luwei16
reslove merge conflict (apache#4350)
01b8a34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. branch-0.13 PR which need to merge to branch 0.13 kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]Using Broker load with ORC file may cause BE crash

2 participants

@WingsGo @morningman