[fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD #43509

hust-hhb · 2024-11-08T07:46:01Z

When delete bitmap count is big, geting delete bitmap may encounter TXN_TOO_OLD, ms should create a new transaction to reading the remaining data instead of returning TXN_TOO_OLD code.

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-08T07:46:06Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

hust-hhb · 2024-11-08T07:46:15Z

run buildall

github-actions · 2024-11-08T07:50:28Z

clang-tidy review says "All clean, LGTM! 👍"

cloud/src/meta-service/meta_service.cpp

cloud/src/common/config.h

cloud/src/meta-service/meta_service.cpp

hust-hhb · 2024-11-11T01:53:58Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-11T01:57:47Z

cloud/test/meta_service_test.cpp

    SyncPoint::get_instance()->clear_all_call_backs();
 }

+TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {


warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]

TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) { ^

Additional context

cloud/test/meta_service_test.cpp:5197: 83 lines including whitespace and comments (threshold 80)

TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) { ^

zhannngchen

LGTM

github-actions · 2024-11-11T07:06:06Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-11T07:06:08Z

PR approved by anyone and no changes requested.

cloud/src/meta-service/meta_service.cpp

hust-hhb · 2024-11-12T04:17:37Z

run buildall

github-actions · 2024-11-12T10:10:36Z

PR approved by at least one committer and no changes requested.

…delete bitmap when encounter TXN_TOO_OLD

hust-hhb · 2024-11-13T06:47:18Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-13T06:51:43Z

cloud/test/meta_service_test.cpp

    SyncPoint::get_instance()->clear_all_call_backs();
 }

+TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) {


warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]

TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) { ^

Additional context

cloud/test/meta_service_test.cpp:5213: 83 lines including whitespace and comments (threshold 80)

TEST(MetaServiceTest, GetDeleteBitmapWithRetryTest2) { ^

github-actions · 2024-11-13T14:44:47Z

PR approved by at least one committer and no changes requested.

zhannngchen

LGTM

…delete bitmap when encounter TXN_TOO_OLD (#44074) When delete bitmap count is big, geting delete bitmap may encounter TXN_TOO_OLD, ms should create a new transaction to reading the remaining data instead of returning TXN_TOO_OLD code. pick pr:#43509

gavinchou reviewed Nov 8, 2024

View reviewed changes

cloud/src/meta-service/meta_service.cpp Outdated Show resolved Hide resolved

gavinchou reviewed Nov 8, 2024

View reviewed changes

cloud/src/common/config.h Outdated Show resolved Hide resolved

zhannngchen reviewed Nov 8, 2024

View reviewed changes

cloud/src/common/config.h Outdated Show resolved Hide resolved

zhannngchen reviewed Nov 8, 2024

View reviewed changes

cloud/src/meta-service/meta_service.cpp Outdated Show resolved Hide resolved

zhannngchen reviewed Nov 8, 2024

View reviewed changes

cloud/src/meta-service/meta_service.cpp Show resolved Hide resolved

github-actions bot reviewed Nov 11, 2024

View reviewed changes

dataroaring added the dev/3.0.x label Nov 11, 2024

zhannngchen previously approved these changes Nov 11, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024

github-actions bot added the reviewed label Nov 11, 2024

gavinchou reviewed Nov 11, 2024

View reviewed changes

cloud/src/meta-service/meta_service.cpp Show resolved Hide resolved

hust-hhb dismissed zhannngchen’s stale review via 33fb683 November 12, 2024 04:16

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 12, 2024

gavinchou previously approved these changes Nov 12, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024

hust-hhb added 3 commits November 13, 2024 14:38

[fix](cloud-mow) MS should create new Transaction to continue geting …

b4d45c3

…delete bitmap when encounter TXN_TOO_OLD

edit

5746c36

edit

ad52507

hust-hhb dismissed gavinchou’s stale review via ad52507 November 13, 2024 06:47

hust-hhb force-pushed the TXN_TOO_OLD branch from 33fb683 to ad52507 Compare November 13, 2024 06:47

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 13, 2024

github-actions bot reviewed Nov 13, 2024

View reviewed changes

gavinchou approved these changes Nov 13, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 13, 2024

zhannngchen approved these changes Nov 13, 2024

View reviewed changes

gavinchou merged commit 00e5ab8 into apache:master Nov 13, 2024

github-actions bot added the cherry-pick-conflict-in-3.0 label Nov 13, 2024

hust-hhb mentioned this pull request Nov 16, 2024

[fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD #44074

Merged

dataroaring added dev/3.0.3-merged and removed dev/3.0.x cherry-pick-conflict-in-3.0 labels Nov 17, 2024

[fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD #43509

[fix](cloud-mow) MS should create new Transaction to continue geting delete bitmap when encounter TXN_TOO_OLD #43509

Uh oh!

Conversation

hust-hhb commented Nov 8, 2024

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

doris-robot commented Nov 8, 2024

Uh oh!

hust-hhb commented Nov 8, 2024

Uh oh!

github-actions bot commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hust-hhb commented Nov 11, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 11, 2024

Uh oh!

github-actions bot commented Nov 11, 2024

Uh oh!

Uh oh!

hust-hhb commented Nov 12, 2024

Uh oh!

github-actions bot commented Nov 12, 2024

Uh oh!

hust-hhb commented Nov 13, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 13, 2024

Uh oh!

zhannngchen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants