[Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351) #4352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuyunfeng
added
area/doris-on-es
wuyunfeng
changed the title
wuyunfeng
reviewed
Aug 17, 2020
| if (usingRandomBackend) { | ||
| for (int i = 0; i < numBe; ++i) { | ||
| candidateBeList.add(backendList.get(beIndex++ % numBe)); | ||
| candidateBeList.add(backendList.get(beIndex++ % backendList.size())); |
Member
There was a problem hiding this comment.
Suggested change
| candidateBeList.add(backendList.get(beIndex++ % backendList.size())); | |
| candidateBeList.add(backendList.get(beIndex++ % size)); |
obtain size = backendList.size() in other place
wuyunfeng
reviewed
Aug 17, 2020
Member
wuyunfeng
left a comment
wuyunfeng
left a comment
There was a problem hiding this comment.
This Looks good to me, but I left some minor comment
Contributor
Author
|
I've obtained size = backendList.size() in the front of loop. Is it better? |
wuyunfeng
approved these changes
Aug 17, 2020
Closed
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Aug 21, 2020
…ache#4351) (apache#4352) resolve the problem of querying ES table always route at same 3 BE nodes because of random strategy
Closed
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue:
#4351