Skip to content

[improvement](statistics)Remove useless stats validation check. (#43279) #43558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jibing-Li merged 1 commit into from
Nov 11, 2024
Merged

[improvement](statistics)Remove useless stats validation check. (#43279) #43558

Jibing-Li merged 1 commit into from
Nov 11, 2024

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Nov 11, 2024

backport: #43279

@doris-robot
Copy link

doris-robot commented Nov 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li
[improvement](statistics)Remove useless stats validation check. (apac…
602ade1 
…he#43279)

Remove useless stats validation check.
Before, we will not load the column stats when table rowCount > 0 and
ndv == 0 and nullCount != rowCount. This is to avoid using invalid
stats.
Now, we remove this validation because the planner side added validation
to the column stats, (see apache#41790).
Besides, after remove of the validation, it is easier to add regression
test using stats injection.
@Jibing-Li Jibing-Li marked this pull request as ready for review November 11, 2024 02:28
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Nov 11, 2024

run buildall

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Nov 11, 2024

run feut

@Jibing-Li Jibing-Li requested a review from morrySnow November 11, 2024 04:06
@Jibing-Li Jibing-Li merged commit c3464c8 into apache:branch-2.0 Nov 11, 2024
@Jibing-Li Jibing-Li deleted the ndvcheck2.0 branch November 11, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow

Assignees

No one assigned

Labels

kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jibing-Li @doris-robot