Skip to content

[Optimize](Variant) move merge_rowsets_schema to sync_tablet_rowsets to make schema more accurate #43580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Nov 11, 2024
Merged

[Optimize](Variant) move merge_rowsets_schema to sync_tablet_rowsets to make schema more accurate #43580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions be/src/cloud/cloud_meta_mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,7 @@ Status CloudMetaMgr::sync_tablet_rowsets(CloudTablet* tablet, bool warmup_delta_
bool version_overlap =
tablet->max_version_unlocked() >= rowsets.front()->start_version();
tablet->add_rowsets(std::move(rowsets), version_overlap, wlock, warmup_delta_data);
RETURN_IF_ERROR(tablet->merge_rowsets_schema());
}
tablet->last_base_compaction_success_time_ms = stats.last_base_compaction_time_ms();
tablet->last_cumu_compaction_success_time_ms = stats.last_cumu_compaction_time_ms();
Expand Down
3 changes: 0 additions & 3 deletions be/src/cloud/cloud_tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,6 @@ Status CloudTablet::sync_rowsets(int64_t query_version, bool warmup_delta_data)
clear_cache();
}

// Merge all rowset schemas within a CloudTablet
RETURN_IF_ERROR(merge_rowsets_schema());

return st;
}

Expand Down
6 changes: 3 additions & 3 deletions be/src/cloud/cloud_tablet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ class CloudTablet final : public BaseTablet {

const auto& rowset_map() const { return _rs_version_map; }

// Merge all rowset schemas within a CloudTablet
Status merge_rowsets_schema();

int64_t last_sync_time_s = 0;
int64_t last_load_time_ms = 0;
int64_t last_base_compaction_success_time_ms = 0;
Expand All @@ -211,9 +214,6 @@ class CloudTablet final : public BaseTablet {

Status sync_if_not_running();

// Merge all rowset schemas within a CloudTablet
Status merge_rowsets_schema();

CloudStorageEngine& _engine;

// this mutex MUST ONLY be used when sync meta
Expand Down