[cherry-pick](branch-30)fix date_floor function return wrong result (#41948) #43588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ``` void resize_fill(size_t n, const T& value) { size_t old_size = this->size(); if (n > old_size) { this->reserve(n); std::fill(t_end(), t_end() + n - old_size, value); } this->c_end = this->c_start + this->byte_size(n); } ``` if n is not greater than old_size, it's will not fill the data with value. so it's not set the null_map flag to 1, it's can't return NULL ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | | +---------------------+--------------------+ 1 row in set (0.03 se ``` after fix: ``` mysql [test_query_qa]>select k11,hour_floor(k11,0) from baseall where k1 = 6; +---------------------+--------------------+ | k11 | hour_floor(k11, 0) | +---------------------+--------------------+ | 2015-03-13 12:36:38 | NULL | +---------------------+--------------------+ 1 row in set (0.03 sec) ```
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick from master (#41948)