Skip to content

[improvement](build index)Optimize failed task check on same tablet (#42295) #43589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 1 commit into from
Nov 12, 2024
Merged

[improvement](build index)Optimize failed task check on same tablet (#42295) #43589

airborne12 merged 1 commit into from
Nov 12, 2024

Conversation

@qidaye
Copy link
Contributor

@qidaye qidaye commented Nov 11, 2024

bp #42295

@qidaye
[improvement](build index)Optimize failed task check on same tablet (a…
aab2649 
…pache#42295)

1. Remove logic for replica majority failure checking
2. Introduce `OBTAIN_LOCK_FAILED` status code both in `status.h` and
`Status.thrift`
3. Add `MIN_FAILED_NUM = 3` for non try_lock_failed failure task. The
task will try 3 times before canceling the job.
4. Add `MAX_FAILED_NUM = 10` for try_lock_failed failure task. The task
will try 10 times before canceling the job.

---------

Co-authored-by: qidaye <luen@selectdb.com>
@doris-robot
Copy link

doris-robot commented Nov 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@qidaye
Copy link
Contributor Author

qidaye commented Nov 11, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 11, 2024

TeamCity be ut coverage result:
Function Coverage: 36.33% (9476/26084)
Line Coverage: 27.88% (78024/279809)
Region Coverage: 26.54% (40018/150770)
Branch Coverage: 23.33% (20325/87128)
Coverage Report: http://coverage.selectdb-in.cc/coverage/aab2649cab412b8e0817f428f7d7dbcb4479a038_aab2649cab412b8e0817f428f7d7dbcb4479a038/report/index.html

@airborne12 airborne12 merged commit 4c224bb into apache:branch-2.1 Nov 12, 2024
@qidaye qidaye deleted the pick_42295_2.1 branch November 12, 2024 02:17
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qidaye @doris-robot @airborne12