Skip to content

Conversation

@morningman
Copy link
Contributor

Proposed changes

  1. select database() will only return database name, without cluster name. [Bug][MySQL compatibility] Query to info schema table does not return correct results. #4361

  2. select user() will return the IP which user connected in. [Bug] select user() stmt does return the IP which user connected in #4360

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/mysql-compatibility Issues or PRs related to the mysql compatibility labels Aug 16, 2020
@morningman morningman self-assigned this Aug 16, 2020
@morningman morningman changed the title [Bug] Fix bug and improve compatibility with mysql protocol [MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocol Aug 16, 2020
}
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two empty lines?

kangkaisen
kangkaisen previously approved these changes Aug 25, 2020
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

morningman-cmy and others added 3 commits August 26, 2020 10:30
1. select database() will only return database name, without cluster name.
2. select user() will return the IP which user connected in.
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added the approved Indicates a PR has been approved by one committer. label Aug 26, 2020
@morningman morningman merged commit 763a42c into apache:master Aug 26, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][MySQL compatibility] Query to info schema table does not return correct results.

5 participants