-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocol #4362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangzhg
reviewed
Aug 20, 2020
| } | ||
| } | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two empty lines?
morningman
commented
Aug 20, 2020
fe/fe-core/src/main/java/org/apache/doris/analysis/InformationFunction.java
Outdated
Show resolved
Hide resolved
kangkaisen
previously approved these changes
Aug 25, 2020
Contributor
kangkaisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
1. select database() will only return database name, without cluster name. 2. select user() will return the IP which user connected in.
f7ebe60 to
b04d5d6
Compare
EmmyMiao87
approved these changes
Aug 26, 2020
Contributor
EmmyMiao87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
area/mysql-compatibility
Issues or PRs related to the mysql compatibility
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
kind/fix
Categorizes issue or PR as related to a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
select database() will only return database name, without cluster name. [Bug][MySQL compatibility] Query to info schema table does not return correct results. #4361
select user() will return the IP which user connected in. [Bug] select user() stmt does return the IP which user connected in #4360
Types of changes
Checklist