Skip to content

[fix] (bloom filter) Fix the bloom filter calculation for date and datetime (#43351) #43622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 2 commits into from
Nov 12, 2024
Merged

[fix] (bloom filter) Fix the bloom filter calculation for date and datetime (#43351) #43622

airborne12 merged 2 commits into from
Nov 12, 2024

Conversation

@csun5285
Copy link
Contributor

@csun5285 csun5285 commented Nov 11, 2024

pick from master #43351

@csun5285
[fix] (bloom filter) Fix the bloom filter calculation for date and da…
fed0635 
…tetime (apache#43351)

### What problem does this PR solve?
Problem Summary:
After adding a bloom filter to the date type, queries return errors
following the upgrade.

Co-authored-by: csun5285 <sunchenyang@selectdb.com>
@doris-robot
Copy link

doris-robot commented Nov 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

csun5285 commented Nov 11, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/olap/date_bloom_filter_test.cpp
// specific language governing permissions and limitations
// under the License.

#include <gtest/gtest.h>
Copy link
Contributor

@github-actions github-actions bot Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

@csun5285
Copy link
Contributor Author

csun5285 commented Nov 11, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 12, 2024

TeamCity be ut coverage result:
Function Coverage: 36.34% (9480/26085)
Line Coverage: 27.90% (78080/279820)
Region Coverage: 26.56% (40039/150776)
Branch Coverage: 23.34% (20335/87128)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5ce2a21572e484a5306117449e7286a3b2d413be_5ce2a21572e484a5306117449e7286a3b2d413be/report/index.html

@airborne12 airborne12 merged commit 15f85e2 into apache:branch-2.1 Nov 12, 2024
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csun5285 @doris-robot @airborne12