-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](group commit) fix NPE in group commit select backend #43629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Nov 11, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
dataroaring
approved these changes
Nov 11, 2024
Contributor
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Problem Summary:
```
2024-11-11 12:00:12,200 WARN (mysql-nio-pool-24123|259) execute Exception. stmt[15559118, 7d88d2401de44f4b-8325fbee3de50791]
java.lang.NullPointerException: Cannot invoke "org.apache.doris.system.Backend.isActive()" because "backend" is null
at org.apache.doris.load.GroupCommitManager.getCachedBackend(GroupCommitManager.java:305) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.load.GroupCommitManager.selectBackendForCloudGroupCommitInternal(GroupCommitManager.java:251) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommitInternal(GroupCommitManager.java:239) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommit(GroupCommitManager.java:203) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.cloud.planner.CloudGroupCommitPlanner.selectBackends(CloudGroupCommitPlanner.java:49) ~[doris-fe.jar:1.2-SNAPSHOT]
```
Co-authored-by: meiyi <meiyi@selectdb.com>
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
Nov 12, 2024
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
Nov 12, 2024
dataroaring
pushed a commit
that referenced
this pull request
Nov 12, 2024
zzzxl1993
pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Nov 12, 2024
) Problem Summary: ``` 2024-11-11 12:00:12,200 WARN (mysql-nio-pool-24123|259) execute Exception. stmt[15559118, 7d88d2401de44f4b-8325fbee3de50791] java.lang.NullPointerException: Cannot invoke "org.apache.doris.system.Backend.isActive()" because "backend" is null at org.apache.doris.load.GroupCommitManager.getCachedBackend(GroupCommitManager.java:305) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForCloudGroupCommitInternal(GroupCommitManager.java:251) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommitInternal(GroupCommitManager.java:239) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommit(GroupCommitManager.java:203) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.cloud.planner.CloudGroupCommitPlanner.selectBackends(CloudGroupCommitPlanner.java:49) ~[doris-fe.jar:1.2-SNAPSHOT] ``` Co-authored-by: meiyi <meiyi@selectdb.com>
924060929
pushed a commit
to 924060929/incubator-doris
that referenced
this pull request
Nov 12, 2024
) Problem Summary: ``` 2024-11-11 12:00:12,200 WARN (mysql-nio-pool-24123|259) execute Exception. stmt[15559118, 7d88d2401de44f4b-8325fbee3de50791] java.lang.NullPointerException: Cannot invoke "org.apache.doris.system.Backend.isActive()" because "backend" is null at org.apache.doris.load.GroupCommitManager.getCachedBackend(GroupCommitManager.java:305) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForCloudGroupCommitInternal(GroupCommitManager.java:251) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommitInternal(GroupCommitManager.java:239) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommit(GroupCommitManager.java:203) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.cloud.planner.CloudGroupCommitPlanner.selectBackends(CloudGroupCommitPlanner.java:49) ~[doris-fe.jar:1.2-SNAPSHOT] ``` Co-authored-by: meiyi <meiyi@selectdb.com>
py023
pushed a commit
to py023/doris
that referenced
this pull request
Nov 13, 2024
) Problem Summary: ``` 2024-11-11 12:00:12,200 WARN (mysql-nio-pool-24123|259) execute Exception. stmt[15559118, 7d88d2401de44f4b-8325fbee3de50791] java.lang.NullPointerException: Cannot invoke "org.apache.doris.system.Backend.isActive()" because "backend" is null at org.apache.doris.load.GroupCommitManager.getCachedBackend(GroupCommitManager.java:305) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForCloudGroupCommitInternal(GroupCommitManager.java:251) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommitInternal(GroupCommitManager.java:239) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommit(GroupCommitManager.java:203) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.cloud.planner.CloudGroupCommitPlanner.selectBackends(CloudGroupCommitPlanner.java:49) ~[doris-fe.jar:1.2-SNAPSHOT] ``` Co-authored-by: meiyi <meiyi@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.8-merged
dev/3.0.3-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)