Skip to content

[fix](ngram bloomfilter) fix narrow conversion for ngram bf_size #43480 #43655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 1 commit into from
Nov 12, 2024
Merged

[fix](ngram bloomfilter) fix narrow conversion for ngram bf_size #43480 #43655

airborne12 merged 1 commit into from
Nov 12, 2024

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Nov 12, 2024

cherry pick from #43480

@airborne12
[fix](ngram bloomfilter) fix narrow conversion for ngram bf_size (apa…
6e8a403 
…che#43480)

Problem Summary:
Fix ngram bloomfilter index coredump as below
```
*** SIGFPE integer divide by zero (@0x56294f026472) received by PID 4016941 (TID 4019213 OR 0x7f294eb4d640) from PID 1325556850; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at be/src/common/signal_handler.h:421
 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in bin/jdk-17.0.2/lib/server/libjvm.so
 2# JVM_handle_linux_signal in bin/jdk-17.0.2/lib/server/libjvm.so
 3# 0x00007F3071042520 in /lib/x86_64-linux-gnu/libc.so.6
 4# doris::segment_v2::NGramBloomFilter::add_bytes(char const*, unsigned int) at be/src/olap/rowset/segment_v2/ngram_bloom_filter.cpp:61
 5# doris::ITokenExtractorHelper<doris::NgramTokenExtractor>::string_to_bloom_filter(char const*, unsigned long, doris::segment_v2::BloomFilter&) const at be/src/olap/itoken_extractor.h:61
 6# doris::segment_v2::NGramBloomFilterIndexWriterImpl::add_values(void const*, unsigned long) at be/src/olap/rowset/segment_v2/bloom_filter_index_writer.cpp:250
```

Co-authored-by: airborne12 <jiangkai@selectdb.com>
@airborne12
Copy link
Member Author

airborne12 commented Nov 12, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Nov 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 12, 2024

TeamCity be ut coverage result:
Function Coverage: 38.55% (8308/21553)
Line Coverage: 30.25% (68686/227086)
Region Coverage: 29.67% (35374/119209)
Branch Coverage: 25.44% (18190/71506)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6e8a4032ab4d7c170d00f77f5a4d45e8ba0165ae_6e8a4032ab4d7c170d00f77f5a4d45e8ba0165ae/report/index.html

@airborne12 airborne12 merged commit 514e79c into apache:branch-2.0 Nov 12, 2024
@airborne12 airborne12 deleted the pick_43480_to_origin_branch-2.0 branch November 12, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/planner Issues or PRs related to the query planner kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@airborne12 @doris-robot