Skip to content

Optimise coding bit operation in BE #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Aug 20, 2020
Merged

Optimise coding bit operation in BE #4366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82dd790
Optimise coding bit operation
ZhangYu0123 Aug 14, 2020
77444f1
add comment
ZhangYu0123 Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion be/src/util/coding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,10 @@ extern uint8_t* encode_varint64(uint8_t* dst, uint64_t value);
inline uint8_t* encode_varint64(uint8_t* dst, uint64_t v) {
static const unsigned int B = 128;
while (v >= B) {
*(dst++) = (v & (B - 1)) | B;
// Fetch low seven bits from current v, and the eight bit is marked as compression mark.
// v | B is optimsed from (v & (B-1)) | B, because result is assgined to uint8_t and other bits
// is cleared by implicit conversion.
*(dst++) = v | B;
v >>= 7;
}
*(dst++) = static_cast<unsigned char>(v);
Expand Down