Skip to content

[Optimize]Optimize the disk selection strategy on BE for tablet creation #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Aug 26, 2020
Merged

[Optimize]Optimize the disk selection strategy on BE for tablet creation #4373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f5b3a
Optimize the disk selection strategy on BE for tablet creation
weizuo93 Aug 13, 2020
d253542
Optimize the disk selection strategy on BE for tablet creation
weizuo93 Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions be/src/olap/data_dir.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ class DataDir {

void update_user_data_size(int64_t size);

std::set<TabletInfo> tablet_set() { return _tablet_set; }

private:
std::string _cluster_id_path() const { return _path + CLUSTER_ID_PREFIX; }
Status _init_cluster_id();
Expand Down
12 changes: 12 additions & 0 deletions be/src/olap/storage_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,18 @@ std::vector<DataDir*> StorageEngine::get_stores_for_create_tablet(
std::random_device rd;
srand(rd());
std::random_shuffle(stores.begin(), stores.end());
// Two random choices
for (int i = 0; i < stores.size(); i++) {
int j = i + 1;
if (j < stores.size()) {
if (stores[i]->tablet_set().size() > stores[j]->tablet_set().size()) {
std::swap(stores[i], stores[j]);
}
std::random_shuffle(stores.begin() + j, stores.end());
} else {
break;
}
}
return stores;
}

Expand Down