Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Nov 12, 2024

What problem does this PR solve?

Problem Summary:
After deserialized from Gson, the ConcurrentHashMap may become normal non-threadsafe HashMap,
This may causing following issue:

2024-11-12 16:43:53,101 ERROR (stateListener|13) [Env.transferToNonMaster():1921] failed to transfer to non-master.
java.util.ConcurrentModificationException: null
        at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:756) ~[?:?]
        at java.util.LinkedHashMap$LinkedValueIterator.next(LinkedHashMap.java:783) ~[?:?]
        at org.apache.doris.datasource.CatalogMgr.registerCatalogRefreshListener(CatalogMgr.java:802) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.postProcessAfterMetadataReplayed(Env.java:1751) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.transferToNonMaster(Env.java:1899) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.access$1300(Env.java:347) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2850) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.common.util.Daemon.run(Daemon.java:119) ~[doris-fe.jar:1.2-SNAPSHOT]

This PR rebuild the idToCatalog and nameToCatalog map in gsonPostProcess() of CatalogMgr,
to solve the issue.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit f87373a into apache:master Nov 14, 2024
github-actions bot pushed a commit that referenced this pull request Nov 14, 2024
### What problem does this PR solve?

Problem Summary:
After deserialized from Gson, the ConcurrentHashMap may become normal
non-threadsafe HashMap,
This may causing following issue:

```
2024-11-12 16:43:53,101 ERROR (stateListener|13) [Env.transferToNonMaster():1921] failed to transfer to non-master.
java.util.ConcurrentModificationException: null
        at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:756) ~[?:?]
        at java.util.LinkedHashMap$LinkedValueIterator.next(LinkedHashMap.java:783) ~[?:?]
        at org.apache.doris.datasource.CatalogMgr.registerCatalogRefreshListener(CatalogMgr.java:802) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.postProcessAfterMetadataReplayed(Env.java:1751) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.transferToNonMaster(Env.java:1899) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env.access$1300(Env.java:347) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2850) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.common.util.Daemon.run(Daemon.java:119) ~[doris-fe.jar:1.2-SNAPSHOT]
```

This PR rebuild the `idToCatalog` and `nameToCatalog` map in
`gsonPostProcess()` of `CatalogMgr`,
to solve the issue.
yiguolei pushed a commit that referenced this pull request Nov 16, 2024
#43963)

Cherry-picked from #43772

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants