[fix](nereids) fix bug: convert stringLikeLiteral to double #43776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
xzj7019
reviewed
Nov 13, 2024
...core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/StringLikeLiteral.java
Show resolved
Hide resolved
morrySnow
approved these changes
Nov 13, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
xzj7019
approved these changes
Nov 13, 2024
Jibing-Li
approved these changes
Nov 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
…ngth (#43776) The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
…ngth (#43776) The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
Nov 13, 2024
…ngth (apache#43776) The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
Nov 13, 2024
…ngth (apache#43776) The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
Nov 13, 2024
…ngth (apache#43776) The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
yiguolei
pushed a commit
that referenced
this pull request
Nov 14, 2024
…ngth (#43776) branch-2.1 (#43911) ### What problem does this PR solve? pick #43776 The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length(). 、
yiguolei
pushed a commit
that referenced
this pull request
Nov 14, 2024
…ngth (#43776) branch-3.0 (#43912) ### What problem does this PR solve? pick #43776 The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
englefly
added a commit
that referenced
this pull request
Nov 15, 2024
…ngth (#43776) branch-2.0 (#43910) ### What problem does this PR solve? pick #43776 The optimizer maps different data types to Double, allowing for a unified comparison of literals. StringLikeLiteral is regarded as a long int, and map the long int to double. To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The optimizer maps different data types to Double, allowing for a unified comparison of literals.
StringLikeLiteral is regarded as a long int, and map the long int to double.
To extract the first N bytes from a string, you should use String.getBytes().length instead of String.length().
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)