Skip to content

[Cherry-pick](rf)fix core dump on rf between varchar and char #43758 #43919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 2 commits into from
Nov 14, 2024
Merged

[Cherry-pick](rf)fix core dump on rf between varchar and char #43758 #43919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8961d70
fix core dump on rf between varchar and char
BiteTheDDDDt Nov 14, 2024
91e2e84
update
BiteTheDDDDt Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/exprs/create_predicate_function.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ ColumnPredicate* create_olap_column_predicate(uint32_t column_id,
std::shared_ptr<BloomFilterFuncBase> filter_olap;
filter_olap.reset(create_bloom_filter(PT));
filter_olap->light_copy(filter.get());
return new BloomFilterColumnPredicate<PT>(column_id, filter);
return new BloomFilterColumnPredicate<PT>(column_id, filter_olap);
}

template <PrimitiveType PT>
Expand Down
4 changes: 3 additions & 1 deletion be/src/olap/bloom_filter_predicate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ class BloomFilterColumnPredicate : public ColumnPredicate {

int get_filter_id() const override {
int filter_id = _filter->get_filter_id();
DCHECK(filter_id != -1);
if (filter_id == 1) {
throw Exception(ErrorCode::INTERNAL_ERROR, "filter_id is -1");
}
return filter_id;
}
bool is_filter() const override { return true; }
Expand Down