Skip to content

Conversation

@stalary
Copy link
Contributor

@stalary stalary commented Aug 19, 2020

Proposed changes

dynamic_partition.replication_num default is replication_num, but show create table show -1

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Further comments

replace DynamicPartitionProperty toString with getProperties

@stalary
Copy link
Contributor Author

stalary commented Aug 19, 2020

The previous branch did not work properly, so I recreated PR. @morningman

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Aug 25, 2020
@morningman morningman added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. labels Aug 25, 2020
@morningman morningman merged commit ca5e224 into apache:master Aug 26, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@stalary stalary deleted the dynamic_replication_num branch November 11, 2022 00:46
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants