Skip to content

[optimization](agg) add float/double type in agg percentile_array #43953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangstar333 merged 1 commit into from
Nov 18, 2024
Merged

[optimization](agg) add float/double type in agg percentile_array #43953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/vec/aggregate_functions/aggregate_function_percentile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void register_aggregate_function_percentile(AggregateFunctionSimpleFactory& fact
creator_with_numeric_type::creator<AggregateFunctionPercentile>);
factory.register_function_both(
"percentile_array",
creator_with_integer_type::creator<AggregateFunctionPercentileArray>);
creator_with_numeric_type::creator<AggregateFunctionPercentileArray>);
}

void register_percentile_approx_old_function(AggregateFunctionSimpleFactory& factory) {
Expand Down
5 changes: 5 additions & 0 deletions ...c/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/PercentileArray.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.doris.nereids.types.ArrayType;
import org.apache.doris.nereids.types.BigIntType;
import org.apache.doris.nereids.types.DoubleType;
import org.apache.doris.nereids.types.FloatType;
import org.apache.doris.nereids.types.IntegerType;
import org.apache.doris.nereids.types.LargeIntType;
import org.apache.doris.nereids.types.SmallIntType;
Expand All @@ -45,6 +46,10 @@ public class PercentileArray extends AggregateFunction
implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNotNullable {

public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
FunctionSignature.ret(ArrayType.of(DoubleType.INSTANCE))
.args(DoubleType.INSTANCE, ArrayType.of(DoubleType.INSTANCE)),
FunctionSignature.ret(ArrayType.of(DoubleType.INSTANCE))
.args(FloatType.INSTANCE, ArrayType.of(DoubleType.INSTANCE)),
FunctionSignature.ret(ArrayType.of(DoubleType.INSTANCE))
.args(LargeIntType.INSTANCE, ArrayType.of(DoubleType.INSTANCE)),
FunctionSignature.ret(ArrayType.of(DoubleType.INSTANCE))
Expand Down
3 changes: 3 additions & 0 deletions ...t/data/nereids_p0/sql_functions/aggregate_functions/test_aggregate_percentile_no_cast.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,6 @@
5 29.0 29.0 29.0 [29, 29, 29]
6 101.0 101.0 101.0 [101, 101, 101]

-- !select --
[19.5, 24.25, 101.325]

17 changes: 17 additions & 0 deletions ...tes/nereids_p0/sql_functions/aggregate_functions/test_aggregate_percentile_no_cast.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,21 @@ suite("test_aggregate_percentile_no_cast") {
sql "INSERT INTO percentile_test_db values(1,10), (2,8), (2,114) ,(3,10) ,(5,29) ,(6,101)"
qt_select "select id,percentile(level,0.5) , percentile(level,0.55) , percentile(level,0.805) , percentile_array(level,[0.5,0.55,0.805])from percentile_test_db group by id order by id"

sql "DROP TABLE IF EXISTS percentile_test_db2"
sql """
CREATE TABLE IF NOT EXISTS percentile_test_db2 (
id int,
level double
)
DISTRIBUTED BY HASH(id) BUCKETS 1
PROPERTIES (
"replication_num" = "1"
)
"""
explain {
sql("""select percentile_array(level,[0.5,0.55,0.805])from percentile_test_db2;""")
notContains("cast")
}
sql "INSERT INTO percentile_test_db2 values(1,10.1), (2,8.2), (2,114.3) ,(3,10.4) ,(5,29.5) ,(6,101.6)"
qt_select "select percentile_array(level,[0.5,0.55,0.805])from percentile_test_db2;"
}