Skip to content

[fix](config) fe config sync_image_timeout_second should not be masterOnly #43954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 21, 2024
Merged

[fix](config) fe config sync_image_timeout_second should not be masterOnly #43954

morningman merged 1 commit into from
Nov 21, 2024

Conversation

@nsnhuang
Copy link
Contributor

@nsnhuang nsnhuang commented Nov 14, 2024

What problem does this PR solve?

sync_image_timeout_second is for the follower，should not be masterOnly

Issue Number: close #xxx

Related PR: #25768

Problem Summary:

Release note

@doris-robot
Copy link

doris-robot commented Nov 14, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

morningman
morningman approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

morningman commented Nov 14, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

PR approved by anyone and no changes requested.

@morningman morningman changed the title [fix] fe config sync_image_timeout_second should not be masterOnly [fix](config) fe config sync_image_timeout_second should not be masterOnly Nov 14, 2024
dataroaring
dataroaring approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 4c58d62 into apache:master Nov 21, 2024
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
@nsnhuang
[fix](config) fe config sync_image_timeout_second should not be maste…
613bcd0 
…rOnly (#43954)

### What problem does this PR solve?
sync_image_timeout_second is for the follower，should not be  masterOnly

Co-authored-by: huangwenbo04 <huangwenbo04@meituan.com>
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
@nsnhuang
[fix](config) fe config sync_image_timeout_second should not be maste…
ae18f58 
…rOnly (#43954)

### What problem does this PR solve?
sync_image_timeout_second is for the follower，should not be  masterOnly

Co-authored-by: huangwenbo04 <huangwenbo04@meituan.com>
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
yiguolei pushed a commit that referenced this pull request Nov 22, 2024
@github-actions @nsnhuang
branch-2.1: [fix](config) fe config sync_image_timeout_second should …
28d7e9f 
…not be masterOnly #43954 (#44384)

Cherry-picked from #43954

Co-authored-by: nsn_huang <38585669+nsnhuang@users.noreply.github.com>
Co-authored-by: huangwenbo04 <huangwenbo04@meituan.com>
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@github-actions @nsnhuang
branch-3.0: [fix](config) fe config sync_image_timeout_second should …
6da8694 
…not be masterOnly #43954 (#44383)

Cherry-picked from #43954

Co-authored-by: nsn_huang <38585669+nsnhuang@users.noreply.github.com>
Co-authored-by: huangwenbo04 <huangwenbo04@meituan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nsnhuang @doris-robot @morningman @dataroaring