Skip to content

[fix](cloud-mow) tablet_id should use int64_t to avoid truncation problem when removing old delete bitmap #43956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Nov 14, 2024
Merged

[fix](cloud-mow) tablet_id should use int64_t to avoid truncation problem when removing old delete bitmap #43956

gavinchou merged 1 commit into from
Nov 14, 2024

Conversation

@hust-hhb
Copy link
Contributor

@hust-hhb hust-hhb commented Nov 14, 2024

tablet_id is int64_t, use int32_t may have truncation problem, which will lead to send wrong tablet_id to ms, and do nothing on remove old delete bitmap

@doris-robot
Copy link

doris-robot commented Nov 14, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Nov 14, 2024

run buildall

dataroaring
dataroaring approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 14, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hust-hhb hust-hhb mentioned this pull request Nov 14, 2024
Merged
@doris-robot
Copy link

doris-robot commented Nov 14, 2024

TeamCity be ut coverage result:
Function Coverage: 37.94% (9888/26060)
Line Coverage: 29.15% (82651/283565)
Region Coverage: 28.27% (42477/150230)
Branch Coverage: 24.85% (21542/86678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/744d8da21878d9d4335f72bdc38c22a93a34559a_744d8da21878d9d4335f72bdc38c22a93a34559a/report/index.html

dataroaring pushed a commit that referenced this pull request Nov 14, 2024
@hust-hhb
[fix](cloud-mow) tablet_id should use int64_t to avoid truncation pro…
27125e6 
…blem when removing old delete bitmap (#43968)

tablet_id is int64_t, use int32_t may have truncation problem, which
will lead to send wrong tablet_id to ms, and do nothing on remove old
delete bitmap
pick:#43956
@gavinchou gavinchou merged commit 75557a5 into apache:master Nov 14, 2024
hubgeter pushed a commit to hubgeter/doris that referenced this pull request Mar 12, 2025
@hust-hhb @gavinchou
[fix](cloud-mow) tablet_id should use int64_t to avoid truncation pro…
8403604 
…blem when removing old delete bitmap (apache#43968) (apache#43956)

tablet_id is int64_t, use int32_t may have truncation problem, which
will lead to send wrong tablet_id to ms, and do nothing on remove old
delete bitmap
pick:apache#43956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hust-hhb @doris-robot @zhannngchen @dataroaring @gavinchou