Skip to content

Conversation

@yiguolei
Copy link
Contributor

@wuyunfeng wuyunfeng changed the title [bugfix] Some deleted tablets are not recycled on BE and occupy too m… [Bug-Fix] Some deleted tablets are not recycled on BE and occupy too m… Aug 20, 2020
@wuyunfeng wuyunfeng added area/storage Issues or PRs related to storage engine kind/fix Categorizes issue or PR as related to a bug. labels Aug 20, 2020
@wuyunfeng wuyunfeng changed the title [Bug-Fix] Some deleted tablets are not recycled on BE and occupy too m… [Bug-Fix] Some deleted tablets are not recycled on BE Aug 20, 2020
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yangzhg
yangzhg previously approved these changes Aug 20, 2020

void TabletManager::unregister_clone_tablet(int64_t tablet_id) {
RWMutex& tablet_map_lock = _get_tablet_map_lock(tablet_id);
ReadLock rlock(&tablet_map_lock);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be WriteLock?

morningman
morningman previously approved these changes Aug 25, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

UT compile failed

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Aug 26, 2020
@morningman morningman merged commit b85bb0e into apache:master Aug 27, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/storage Issues or PRs related to storage engine kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants