Skip to content

branch-3.0: [Fix](ShortCircuit) fix open segments leading to bad performace #44073 #44077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Nov 17, 2024
Merged

branch-3.0: [Fix](ShortCircuit) fix open segments leading to bad performace #44073 #44077

dataroaring merged 1 commit into from
Nov 17, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 16, 2024

Cherry-picked from #44073

@eldenmoon
[Fix](ShortCircuit) fix open segments leading to bad performace (#44073)
e6306c7 
No need need to open segments for all rowsets, only open in
`lookup_row_key` stage.

Introduced by #42697
@doris-robot
Copy link

doris-robot commented Nov 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Nov 16, 2024

run buildall

@dataroaring dataroaring reopened this Nov 17, 2024
@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring dataroaring merged commit 502126a into branch-3.0 Nov 17, 2024
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Closed
@dataroaring dataroaring deleted the auto-pick-44073-branch-3.0 branch December 27, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@doris-robot @dataroaring @eldenmoon