branch-3.0: [opt](inverted index) add performance profiling for remote io access in inverted index #43542 #44093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in inverted index (#43542) Problem Summary: 1. Implement the accounting of remote I/O operations for the inverted index in profiling statistics. ### Release note Add performance profiling for remote IO access in inverted index
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Status FullTextIndexReader::query(OlapReaderStatistics* stats, RuntimeState* runtime_state, | ||
| const std::string& column_name, const void* query_value, | ||
| InvertedIndexQueryType query_type, | ||
| Status FullTextIndexReader::query(const io::IOContext* io_ctx, OlapReaderStatistics* stats, |
Contributor
Author
There was a problem hiding this comment.
warning: function 'query' exceeds recommended size/complexity thresholds [readability-function-size]
Status FullTextIndexReader::query(const io::IOContext* io_ctx, OlapReaderStatistics* stats,
^Additional context
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:248: 92 lines including whitespace and comments (threshold 80)
Status FullTextIndexReader::query(const io::IOContext* io_ctx, OlapReaderStatistics* stats,
^| } | ||
|
|
||
| Status StringTypeInvertedIndexReader::query(OlapReaderStatistics* stats, | ||
| Status StringTypeInvertedIndexReader::query(const io::IOContext* io_ctx, |
Contributor
Author
There was a problem hiding this comment.
warning: function 'query' exceeds recommended size/complexity thresholds [readability-function-size]
Status StringTypeInvertedIndexReader::query(const io::IOContext* io_ctx,
^Additional context
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:357: 117 lines including whitespace and comments (threshold 80)
Status StringTypeInvertedIndexReader::query(const io::IOContext* io_ctx,
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #43542