Skip to content

[fix](load) fix broker load progress due to retry (#42959) #44123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liaoxin01 merged 1 commit into from
Nov 18, 2024
Merged

[fix](load) fix broker load progress due to retry (#42959) #44123

liaoxin01 merged 1 commit into from
Nov 18, 2024

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Nov 18, 2024

backport #42959

@kaijchen
[fix](load) fix broker load progress due to retry (apache#42959)
566b788 
Currently, when retrying a broker load, it will use a different
`load_id` with the same `job_id`.
The `total_scan_nums` in progress is accumulated by `job_id`.
This will cause the `total_scan_nums` progress to be multiple of the
actual scan nums.

For example, suppose a 10 instance broker load gets retried:

```
initial (0/10) 0% -> retry (0/20) 0% -> finish (10/20) 50%
```
@kaijchen
Copy link
Member Author

kaijchen commented Nov 18, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Nov 18, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01 liaoxin01 merged commit 8472658 into apache:branch-2.1 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaijchen @doris-robot @liaoxin01