Skip to content

branch-3.0: [fix](cloud) explicit message when parse file_cache_path error #44004 #44157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Nov 26, 2024
Merged

branch-3.0: [fix](cloud) explicit message when parse file_cache_path error #44004 #44157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion be/src/olap/options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,10 @@ Status parse_conf_cache_paths(const std::string& config_path, std::vector<CacheP
} else if (has_normal_percent || has_disposable_percent || has_index_percent ||
has_ttl_percent) {
return Status::InvalidArgument(
"cache percent config must either be all set or all unset.");
"cache percent (ttl_percent, index_percent, normal_percent, "
"disposable_percent) must either be all set or all unset. "
"when all unset, use default: ttl_percent=50, index_percent=5, "
"normal_percent=40, disposable_percent=5.");
}
if ((normal_percent + disposable_percent + index_percent + ttl_percent) != 100) {
return Status::InvalidArgument("The sum of cache percent config must equal 100.");
Expand Down
4 changes: 2 additions & 2 deletions be/src/runtime/exec_env_init.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,8 @@ void ExecEnv::init_file_cache_factory(std::vector<doris::CachePath>& cache_paths
std::unordered_set<std::string> cache_path_set;
Status rest = doris::parse_conf_cache_paths(doris::config::file_cache_path, cache_paths);
if (!rest) {
LOG(FATAL) << "parse config file cache path failed, path="
<< doris::config::file_cache_path;
LOG(FATAL) << "parse config file cache path failed, path=" << doris::config::file_cache_path
<< ", reason=" << rest.msg();
exit(-1);
}
std::vector<std::thread> file_cache_init_threads;
Expand Down