[cherry-pick](branch-30) fix exchange of tablet shuffle send block error (#44102) #44166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…he#44102) Problem Summary: the _batching_block is same as block which is used for output. and maybe different with input block in some column about nullable type. so if sink this will cause nullable type not equal as origin. ``` Status VRowDistribution::generate_rows_distribution( vectorized::Block& input_block, std::shared_ptr<vectorized::Block>& block, int64_t& filtered_rows, bool& has_filtered_rows, std::vector<RowPartTabletIds>& row_part_tablet_ids, int64_t& rows_stat_val) ....... // batching block rows which need new partitions. deal together at finish. if (!_batching_block) [[unlikely]] { std::unique_ptr<Block> tmp_block = block->create_same_struct_block(0); _batching_block = MutableBlock::create_unique(std::move(*tmp_block)); } ``` ``` void OlapTableBlockConvertor::_convert_to_dest_desc_block(doris::vectorized::Block* block) { for (int i = 0; i < _output_tuple_desc->slots().size() && i < block->columns(); ++i) { SlotDescriptor* desc = _output_tuple_desc->slots()[i]; if (desc->is_nullable() != block->get_by_position(i).type->is_nullable()) { if (desc->is_nullable()) { block->get_by_position(i).type = vectorized::make_nullable(block->get_by_position(i).type); block->get_by_position(i).column = vectorized::make_nullable(block->get_by_position(i).column); } else { block->get_by_position(i).type = assert_cast<const vectorized::DataTypeNullable&>( *block->get_by_position(i).type) .get_nested_type(); block->get_by_position(i).column = assert_cast<const vectorized::ColumnNullable&>( *block->get_by_position(i).column) .get_nested_column_ptr(); } } } } ```
zhangstar333
force-pushed
the
branch-3.0-pick-1118
branch
from
b29401b to
ba8f83e
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick from master (#44102)