Skip to content

Conversation

@acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Aug 22, 2020

Proposed changes

Sometimes we want to detect the hotspot of a cluster, for example, hot scanned tablet, hot wrote tablet, but we have no insight about tablets in the cluster.
This patch introduce tablet level metrics to help to achieve this object, now support 4 metrics on tablets: query_scan_bytes , query_scan_rows , flush_bytes , flush_count . However, one BE may holds hundreds of thousands of tablets, so I add a parameter for the metrics HTTP request, and not return tablet level metrics by default.
ref #3517 #4027

In order to support re-register a same MetricEnity to MetricRegistry, and re-register a same Metric to MetricEntity I also redesign the metric structure.
ref #4396

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I will run it in our test env to see if it can pass all tests.

@morningman morningman self-assigned this Aug 25, 2020
@morningman morningman added kind/feature Categorizes issue or PR as related to a new feature. kind/refactor Issues or PRs to refactor code labels Aug 25, 2020
@acelyc111
Copy link
Member Author

LGTM, but I will run it in our test env to see if it can pass all tests.

@morningman Have you tested in your test env?

@morningman
Copy link
Contributor

LGTM, but I will run it in our test env to see if it can pass all tests.

@morningman Have you tested in your test env?

not yet, there are some bugs in trunk code so the test env failed to pass. I have to fix these bugs first before running your code. Maybe tomorrow.

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Sep 1, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 498b06f into apache:master Sep 2, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature. kind/refactor Issues or PRs to refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants