Skip to content

Conversation

@morrySnow
Copy link
Contributor

What problem does this PR solve?

Related PR: #37219

Problem Summary:

when child's output is hash distribution, repeat's output follow child only when all child's hash columns in all repeat set. otherwise, repeat's output should be any.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

related PR apache#37219

when child's output is hash distribution, repeat's output
follow child only when all child's hash columns in all
repeat set. otherwise, repeat's output should be any.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 44991 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a0d33891d6d638439b4f849c05d5e5ea6a12b3b8, data reload: false

------ Round 1 ----------------------------------
q1	17587	7425	7367	7367
q2	2254	1164	1167	1164
q3	9960	1166	1169	1166
q4	10217	767	725	725
q5	7567	2697	2674	2674
q6	238	146	146	146
q7	1020	636	591	591
q8	9350	2371	2351	2351
q9	6594	6407	6423	6407
q10	7039	2249	2305	2249
q11	462	262	253	253
q12	465	212	225	212
q13	17801	3033	3051	3033
q14	246	208	209	208
q15	580	529	535	529
q16	649	594	569	569
q17	981	611	475	475
q18	7200	6761	6785	6761
q19	1347	1003	1018	1003
q20	2874	2678	2674	2674
q21	4029	3235	3090	3090
q22	1383	1362	1344	1344
Total cold run time: 109843 ms
Total hot run time: 44991 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7568	7282	7404	7282
q2	326	233	236	233
q3	3068	2961	3054	2961
q4	2066	1820	1808	1808
q5	5668	5671	5772	5671
q6	224	143	147	143
q7	2240	1813	1801	1801
q8	3348	3606	3519	3519
q9	8875	8916	8863	8863
q10	3583	3621	3597	3597
q11	589	510	503	503
q12	820	640	606	606
q13	11294	3226	3257	3226
q14	316	283	268	268
q15	566	519	524	519
q16	681	635	634	634
q17	1872	1647	1609	1609
q18	8263	7760	7689	7689
q19	1708	1418	1543	1418
q20	2149	1868	1928	1868
q21	5642	5427	5484	5427
q22	629	556	572	556
Total cold run time: 71495 ms
Total hot run time: 60201 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a0d33891d6d638439b4f849c05d5e5ea6a12b3b8, data reload: false

query1	0.03	0.05	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.43	0.42	0.42
query6	1.15	0.68	0.65
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.58	0.51	0.50
query10	0.55	0.55	0.56
query11	0.15	0.10	0.10
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	2.69	2.87	2.81
query15	0.90	0.82	0.83
query16	0.39	0.37	0.39
query17	1.05	1.03	1.03
query18	0.20	0.20	0.19
query19	1.95	1.80	1.95
query20	0.01	0.01	0.00
query21	15.35	0.57	0.60
query22	2.43	2.24	1.86
query23	17.03	0.91	0.88
query24	2.64	1.42	0.68
query25	0.21	0.14	0.16
query26	0.35	0.14	0.13
query27	0.04	0.05	0.04
query28	10.97	1.09	1.08
query29	12.56	3.19	3.22
query30	0.24	0.06	0.06
query31	2.85	0.38	0.37
query32	3.28	0.47	0.48
query33	3.00	3.00	2.99
query34	16.97	4.51	4.52
query35	4.55	4.56	4.55
query36	0.65	0.49	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.02	0.03
Total cold run time: 106.43 s
Total hot run time: 32.53 s

@wm1581066 wm1581066 added the usercase Important user case type label label Nov 20, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit dda9e8b into apache:master Nov 20, 2024
@morrySnow morrySnow deleted the fix_repeat_properties branch November 20, 2024 08:07
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
Related PR: #37219

Problem Summary:
when child's output is hash distribution, repeat's output follow child
only when all child's hash columns in all repeat set. otherwise,
repeat's output should be any.
morrySnow added a commit that referenced this pull request Nov 22, 2024
…4297 (#44336)

Cherry-picked from #44297

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged p0_b reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants